diff options
| author |  gregce <gregce@google.com> | 2018-04-04 14:49:29 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-04-04 14:50:44 -0700 |
| commit | 46618b1bce1dda4dec8e9e6c94232a8731b237f1 (patch) | |
| tree | 9bbeb93a6ca1b92cc52f9622410d4d29b2d6e7bd /src/main/java/com/google/devtools/build | |
| parent | 2a5512fa3041df96b140e96a30112d5137be8b63 (diff) | |
Disallow empty environment groups.
PiperOrigin-RevId: 191651271
Diffstat (limited to 'src/main/java/com/google/devtools/build')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java b/src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java index 750ccf2658..873934e2e7 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java +++ b/src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java @@ -630,6 +630,10 @@ public final class PackageFactory { List<Label> defaults = BuildType.LABEL_LIST.convert(defaultsList, "'environment_group argument'", context.pkgBuilder.getBuildFileLabel()); + if (environments.isEmpty()) { + throw new EvalException(location, + "environment group " + name + " must contain at least one environment"); + } try { context.pkgBuilder.addEnvironmentGroup( name, environments, defaults, context.eventHandler, loc); |