aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build
diff options
context:
space:
mode:
authorGravatar Philipp Wollermann <philwo@google.com>2015-08-25 13:05:09 +0000
committerGravatar Lukacs Berki <lberki@google.com>2015-08-26 07:37:10 +0000
commit15ab6ad6fbd09352ced025397891de2ea6d5bb7d (patch)
treeef29e5071e08dd1b3ea018ade0c8bf96e8a793ec /src/main/java/com/google/devtools/build
parent43c4a1a1452603bfe5e6883626c5ac91ea4e8eb6 (diff)
Replace quick hack for handling non-sandboxable spawns with a better solution.
-- MOS_MIGRATED_REVID=101458091
Diffstat (limited to 'src/main/java/com/google/devtools/build')
-rw-r--r--src/main/java/com/google/devtools/build/lib/sandbox/LinuxSandboxedStrategy.java6
1 files changed, 2 insertions, 4 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/sandbox/LinuxSandboxedStrategy.java b/src/main/java/com/google/devtools/build/lib/sandbox/LinuxSandboxedStrategy.java
index 67aebeecc8..26a5650048 100644
--- a/src/main/java/com/google/devtools/build/lib/sandbox/LinuxSandboxedStrategy.java
+++ b/src/main/java/com/google/devtools/build/lib/sandbox/LinuxSandboxedStrategy.java
@@ -94,10 +94,8 @@ public class LinuxSandboxedStrategy implements SpawnActionContext {
throws ExecException {
Executor executor = actionExecutionContext.getExecutor();
- // TODO(philwo) - this catches BuildInfo, which can't run in a sandbox. Is there a better way?
- // Maybe add an annotation to actions that they can refuse to run under certain strategies?
- if (spawn.getOwner().getLabel() == null
- || spawn.getArguments().get(0).contains("build-runfiles")) {
+ // Certain actions can't run remotely or in a sandbox - pass them on to the standalone strategy.
+ if (!spawn.isRemotable()) {
standaloneStrategy.exec(spawn, actionExecutionContext);
return;
}