aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build
diff options
context:
space:
mode:
authorGravatar Michael Staib <mstaib@google.com>2016-04-18 20:14:41 +0000
committerGravatar Damien Martin-Guillerez <dmarting@google.com>2016-04-19 09:46:40 +0000
commit08fb617b7e853e05a7536e9d078d46c4c040bb5e (patch)
treebaac53abdee4d29d407d68a96f35afcbcf6b6b4c /src/main/java/com/google/devtools/build
parentaf7e2404a94dee5538067dbba6dbf82334f91563 (diff)
Check for the presence of an AndroidSdkProvider in JackAspect.
If no AndroidSdkProvider is present, JackAspect exits with an error instead of throwing and thus crashing Bazel. This is acceptable; the Android rules which JackAspect is attached to will do the same. -- MOS_MIGRATED_REVID=120150996
Diffstat (limited to 'src/main/java/com/google/devtools/build')
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/android/JackAspect.java3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/android/JackAspect.java b/src/main/java/com/google/devtools/build/lib/rules/android/JackAspect.java
index a167f38ba9..60a912d774 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/android/JackAspect.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/android/JackAspect.java
@@ -63,6 +63,9 @@ public final class JackAspect implements NativeAspectFactory, ConfiguredAspectFa
ruleContext
.getAnalysisEnvironment()
.getDerivedArtifact(jackLibraryPath, ruleContext.getBinOrGenfilesDirectory());
+ if (!AndroidSdkProvider.verifyPresence(ruleContext)) {
+ return null;
+ }
AndroidSdkProvider androidSdk = AndroidSdkProvider.fromRuleContext(ruleContext);
JackCompilationHelper jackHelper =
new JackCompilationHelper.Builder()