In inlined skylark import lookup function caching, don't actually fetch deps when all we want to do is register an edge and don't require the value.

PiperOrigin-RevId: 191966203

2 files changed, 18 insertions, 0 deletions

diff --git a/src/main/java/com/google/devtools/build/skyframe/SkyFunction.java b/src/main/java/com/google/devtools/build/skyframe/SkyFunction.java
index 9b7c29d2e2..527fae3f86 100644
--- a/src/main/java/com/google/devtools/build/skyframe/SkyFunction.java
+++ b/src/main/java/com/google/devtools/build/skyframe/SkyFunction.java
@@ -284,6 +284,13 @@ public interface SkyFunction {
       return null;
     }
 
+    /**
+     * Register dependencies on keys without necessarily requiring their values.
+     */
+    default void registerDependencies(Iterable<SkyKey> keys) throws InterruptedException {
+      getValues(keys);
+    }
+
     /** Returns whether we are currently in error bubbling. */
     @VisibleForTesting
     boolean inErrorBubblingForTesting();
diff --git a/src/main/java/com/google/devtools/build/skyframe/SkyFunctionEnvironment.java b/src/main/java/com/google/devtools/build/skyframe/SkyFunctionEnvironment.java
index cff9f46f15..6546cc8bb8 100644
--- a/src/main/java/com/google/devtools/build/skyframe/SkyFunctionEnvironment.java
+++ b/src/main/java/com/google/devtools/build/skyframe/SkyFunctionEnvironment.java
@@ -621,4 +621,15 @@ class SkyFunctionEnvironment extends AbstractSkyFunctionEnvironment {
   public boolean inErrorBubblingForTesting() {
     return bubbleErrorInfo != null;
   }
+
+  @Override
+  public void registerDependencies(Iterable<SkyKey> keys) {
+    newlyRequestedDeps.startGroup();
+    for (SkyKey key : keys) {
+      if (!directDeps.containsKey(key)) {
+        addDep(key);
+      }
+    }
+    newlyRequestedDeps.endGroup();
+  }
 }