aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/skyframe
diff options
context:
space:
mode:
authorGravatar Michajlo Matijkiw <michajlo@google.com>2015-06-19 19:23:16 +0000
committerGravatar Laszlo Csomor <laszlocsomor@google.com>2015-06-23 08:59:19 +0000
commit2b71efec6c233b937b089bd80f420491e2d52db9 (patch)
treec2d4b892c9fde82133d1a393c065da17d1fee6dd /src/main/java/com/google/devtools/build/skyframe
parent27fd17be3b84dd841578b9f15ef91cba8d0be1d8 (diff)
Log SkyKeys detected changed across builds
Similar to previous approach, except diff-awareness agnostic. Log SkyKeys as is for simplicity- this is all for human consumption anyway. -- MOS_MIGRATED_REVID=96428248
Diffstat (limited to 'src/main/java/com/google/devtools/build/skyframe')
-rw-r--r--src/main/java/com/google/devtools/build/skyframe/Differencer.java3
-rw-r--r--src/main/java/com/google/devtools/build/skyframe/ImmutableDiff.java3
2 files changed, 4 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/skyframe/Differencer.java b/src/main/java/com/google/devtools/build/skyframe/Differencer.java
index f6433acde3..b520f16203 100644
--- a/src/main/java/com/google/devtools/build/skyframe/Differencer.java
+++ b/src/main/java/com/google/devtools/build/skyframe/Differencer.java
@@ -13,6 +13,7 @@
// limitations under the License.
package com.google.devtools.build.skyframe;
+import java.util.Collection;
import java.util.Map;
/**
@@ -27,7 +28,7 @@ public interface Differencer {
/**
* Returns the value keys whose values have changed, but for which we don't have the new values.
*/
- Iterable<SkyKey> changedKeysWithoutNewValues();
+ Collection<SkyKey> changedKeysWithoutNewValues();
/**
* Returns the value keys whose values have changed, along with their new values.
diff --git a/src/main/java/com/google/devtools/build/skyframe/ImmutableDiff.java b/src/main/java/com/google/devtools/build/skyframe/ImmutableDiff.java
index 46ab29e851..987d03cddc 100644
--- a/src/main/java/com/google/devtools/build/skyframe/ImmutableDiff.java
+++ b/src/main/java/com/google/devtools/build/skyframe/ImmutableDiff.java
@@ -16,6 +16,7 @@ package com.google.devtools.build.skyframe;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
+import java.util.Collection;
import java.util.Map;
/**
@@ -32,7 +33,7 @@ public class ImmutableDiff implements Differencer.Diff {
}
@Override
- public Iterable<SkyKey> changedKeysWithoutNewValues() {
+ public Collection<SkyKey> changedKeysWithoutNewValues() {
return valuesToInvalidate;
}