aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java
diff options
context:
space:
mode:
authorGravatar janakr <janakr@google.com>2018-06-19 09:45:57 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-06-19 09:47:43 -0700
commit9b0b987e5df9a7e5d5c7cc09ed37d5ccaa8eb54e (patch)
tree645c55142ebbc5eaea868551cac7bd4acca3ce70 /src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java
parentd39de3a8849974c30609a2bc190fcbba6c237143 (diff)
Clarify that ErrorInfoValue is a NotComparableSkyValue because we don't expect equality, not because there's no implementation.
PiperOrigin-RevId: 201191262
Diffstat (limited to 'src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java')
-rw-r--r--src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java b/src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java
index a0c5108590..8254f2eaf3 100644
--- a/src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java
+++ b/src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java
@@ -179,10 +179,10 @@ public abstract class ValueWithMetadata implements SkyValue {
/**
* Implementation of {@link ValueWithMetadata} for the error case.
*
- * ErorInfo does not override equals(), so it may as well be marked NotComparableSkyValue.
+ * <p>Mark NotComparableSkyValue because it's unlikely that re-evaluation gives the same error.
*/
private static final class ErrorInfoValue extends ValueWithMetadata
- implements NotComparableSkyValue {
+ implements NotComparableSkyValue {
private final ErrorInfo errorInfo;
private final NestedSet<TaggedEvents> transitiveEvents;