diff options
author | 2017-07-20 18:53:24 +0200 | |
---|---|---|
committer | 2017-07-21 09:13:46 +0200 | |
commit | 28ad27e5ef060174adf3a425ba63cd7e87ceb5a2 (patch) | |
tree | 3525b79ba139a88f9d7ff265eebfe2cd5864a2ba /src/main/java/com/google/devtools/build/skyframe/SimpleCycleDetector.java | |
parent | 1059104d828e995949943a354d92606d5fa73e78 (diff) |
Support multiple --define's in config_setting.
This fixes the problem that
config_setting(
name = "a_and_b",
values = {
"define": "a=c",
"define": "b=d"
})
doesn't work as expected because BUILD parsing removes duplicate dictionary keys in accordance with Pythonic behavior. Even worse, Skylark will soon enforce this more aggressively by making this an outright error.
This change introduces the define_values attribute:
config_setting(
name = "a_and_b",
values = {
"normal_flag": "normal_value",
},
define_values = {
"a: "c",
"b": "d"
})
This is equivalent to "$ bazel build ... --normal_flag=normal_value --define a=c --define b=d" at the command line.
Also tried to clean up some ConfigSetting naming for clarity around the different kind of flags.
PiperOrigin-RevId: 162627180
Diffstat (limited to 'src/main/java/com/google/devtools/build/skyframe/SimpleCycleDetector.java')
0 files changed, 0 insertions, 0 deletions