Avoid list copy in BuildingState.getNextDirtyDirectDeps

Also, in GroupedList, short-circuit expensive group equality check
with a reference check, saving time and garbage when groups are the
same object.

--
MOS_MIGRATED_REVID=109795332

1 files changed, 2 insertions, 1 deletions

diff --git a/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java b/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java
index 802e940f69..e9c18b136b 100644
--- a/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java
+++ b/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java
@@ -869,7 +869,8 @@ public final class ParallelEvaluator implements Evaluator {
           // in #invalidatedByErrorTransience means that the error transience node is not newer
           // than this node, so we are going to mark it clean (since the error transience node is
           // always the last dep).
-          state.addTemporaryDirectDeps(GroupedListHelper.create(directDepsToCheck));
+          state.addTemporaryDirectDepsGroupToDirtyEntry(directDepsToCheck);
+
           for (Map.Entry<SkyKey, NodeEntry> e
               : graph.createIfAbsentBatch(directDepsToCheck).entrySet()) {
             SkyKey directDep = e.getKey();