diff options
| author |  ulfjack <ulfjack@google.com> | 2017-07-18 10:12:09 +0200 |
|---|---|---|
| committer |  Klaus Aehlig <aehlig@google.com> | 2017-07-18 11:41:14 +0200 |
| commit | 52b4f68592df562dd9f1e28208a1bde72b86a721 (patch) | |
| tree | e766dd60d843a92d38bcd1fd0899460e9c440851 /src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java | |
| parent | 820a46af10808396873c36d0f331e533118cf0c6 (diff) | |
Fix Postable forwarding and replay
We were previously duplicate-posting Postable events posted to the
Skyframe environment.
PiperOrigin-RevId: 162323598
Diffstat (limited to 'src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java')
| -rw-r--r-- | src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java b/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java index beb4a2548b..aac9277a1d 100644 --- a/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java +++ b/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java @@ -23,7 +23,6 @@ import com.google.common.collect.Iterables; import com.google.devtools.build.lib.concurrent.ThreadSafety.ThreadCompatible; import com.google.devtools.build.lib.events.Event; import com.google.devtools.build.lib.events.ExtendedEventHandler; -import com.google.devtools.build.lib.events.ExtendedEventHandler.Postable; import com.google.devtools.build.lib.profiler.Profiler; import com.google.devtools.build.lib.profiler.ProfilerTask; import com.google.devtools.build.lib.util.BlazeClock; @@ -1088,9 +1087,9 @@ public final class ParallelEvaluator implements Evaluator { continue; } SkyValue value = valueWithMetadata.getValue(); - for (Postable post : valueWithMetadata.getTransitivePostables()) { - evaluatorContext.getReporter().post(post); - } + evaluatorContext + .getReplayingNestedSetPostableVisitor() + .visit(valueWithMetadata.getTransitivePostables()); // TODO(bazel-team): Verify that message replay is fast and works in failure // modes [skyframe-core] // Note that replaying events here is only necessary on null builds, because otherwise we |