diff options
| author |  janakr <janakr@google.com> | 2017-10-10 03:22:21 +0200 |
|---|---|---|
| committer |  Marcel Hlopko <hlopko@google.com> | 2017-10-10 11:22:49 +0200 |
| commit | 1cde8722b930f1c9cf5346f887a0b293bae49f1f (patch) | |
| tree | fc690c495c8c4534f7b1fc7ff989f528fc53f11a /src/main/java/com/google/devtools/build/skyframe/MemoizingEvaluator.java | |
| parent | 6f411661984a9be358c5b457b31c88368d6fdd63 (diff) | |
Allow NodeEntry implementations to keep just deps, as opposed to all edges or no edges. Also add option to disable checks in MemoizingEvaluatorTest that don't make sense for implementations that don't keep track of dirty nodes. Also extract RecordingDifferencer to an interface. And add a test for the situation that a node changes during a build that it's not requested, and which fails, necessitating cleanup.
PiperOrigin-RevId: 171616817
Diffstat (limited to 'src/main/java/com/google/devtools/build/skyframe/MemoizingEvaluator.java')
| -rw-r--r-- | src/main/java/com/google/devtools/build/skyframe/MemoizingEvaluator.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/skyframe/MemoizingEvaluator.java b/src/main/java/com/google/devtools/build/skyframe/MemoizingEvaluator.java index 889c9df7b8..562c2eaebc 100644 --- a/src/main/java/com/google/devtools/build/skyframe/MemoizingEvaluator.java +++ b/src/main/java/com/google/devtools/build/skyframe/MemoizingEvaluator.java @@ -113,7 +113,7 @@ public interface MemoizingEvaluator { */ @VisibleForTesting @Nullable - SkyValue getExistingValue(SkyKey key); + SkyValue getExistingValue(SkyKey key) throws InterruptedException; /** * Returns an error if and only if an earlier call to {@link #evaluate} created it; null @@ -127,7 +127,7 @@ public interface MemoizingEvaluator { ErrorInfo getExistingErrorForTesting(SkyKey key) throws InterruptedException; @Nullable - NodeEntry getExistingEntryForTesting(SkyKey key); + NodeEntry getExistingEntryForTesting(SkyKey key) throws InterruptedException; /** * Tests that want finer control over the graph being used may provide a {@code transformer} here. |