Batch retrieval of children when removing reverse deps.

--
MOS_MIGRATED_REVID=97022077

1 files changed, 6 insertions, 2 deletions

diff --git a/src/main/java/com/google/devtools/build/skyframe/InvalidatingNodeVisitor.java b/src/main/java/com/google/devtools/build/skyframe/InvalidatingNodeVisitor.java
index 7abf6c6f8a..558bbd2593 100644
--- a/src/main/java/com/google/devtools/build/skyframe/InvalidatingNodeVisitor.java
+++ b/src/main/java/com/google/devtools/build/skyframe/InvalidatingNodeVisitor.java
@@ -24,6 +24,7 @@ import com.google.devtools.build.lib.concurrent.AbstractQueueVisitor;
 import com.google.devtools.build.lib.concurrent.ThreadSafety.ThreadSafe;
 import com.google.devtools.build.lib.util.Pair;
 
+import java.util.Collection;
 import java.util.Set;
 import java.util.concurrent.TimeUnit;
 
@@ -334,8 +335,11 @@ public abstract class InvalidatingNodeVisitor extends AbstractQueueVisitor {
 
           // Remove this node as a reverse dep from its children, since we have reset it and it no
           // longer lists its children as direct deps.
-          for (SkyKey dep : depsAndValue.first) {
-            graph.get(dep).removeReverseDep(key);
+          Collection<NodeEntry> children = graph.getBatch(depsAndValue.first).values();
+          Preconditions.checkState(children.size() == Iterables.size(depsAndValue.first),
+              "%s %s %s %s", key, entry, depsAndValue.first, children);
+          for (NodeEntry child : children) {
+            child.removeReverseDep(key);
           }
 
           SkyValue value = ValueWithMetadata.justValue(depsAndValue.second);