aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib
diff options
context:
space:
mode:
authorGravatar kmb <kmb@google.com>2018-04-24 21:48:14 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-04-24 21:49:46 -0700
commite48ceba478b7fc1c4b22ff77bd61bd134848aa74 (patch)
tree670c22d589f4f95fce41ce65636b8540dc764d02 /src/main/java/com/google/devtools/build/lib
parentd8a21e30630f4eddcd076821577a2ba9a7c110f0 (diff)
Remove no-op check from AndroidCommon, add missing rule validation to aar_import
PiperOrigin-RevId: 194191933
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib')
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/android/AarImport.java1
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/android/AndroidCommon.java2
2 files changed, 1 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/android/AarImport.java b/src/main/java/com/google/devtools/build/lib/rules/android/AarImport.java
index fcf851aae6..a85c74191a 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/android/AarImport.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/android/AarImport.java
@@ -150,6 +150,7 @@ public class AarImport implements RuleConfiguredTargetFactory {
/* compileDeps = */ targets,
/* runtimeDeps = */ targets,
/* bothDeps = */ targets);
+ javaSemantics.checkRule(ruleContext, common);
common.setJavaCompilationArtifacts(
new JavaCompilationArtifacts.Builder()
diff --git a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidCommon.java b/src/main/java/com/google/devtools/build/lib/rules/android/AndroidCommon.java
index dd8df831e1..7240e132c3 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidCommon.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/android/AndroidCommon.java
@@ -555,8 +555,6 @@ public class AndroidCommon {
helper.addLibrariesToAttributes(javaCommon.targetsTreatedAsDeps(ClasspathType.COMPILE_ONLY));
attributes.setTargetLabel(ruleContext.getLabel());
- JavaCommon.validateConstraint(
- ruleContext, "android", javaCommon.targetsTreatedAsDeps(ClasspathType.BOTH));
ruleContext.checkSrcsSamePackage(true);
return helper;
}