aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib
diff options
context:
space:
mode:
authorGravatar Googler <noreply@google.com>2018-04-13 16:04:21 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-04-13 16:06:21 -0700
commitb9240df02a56bf4c6b52c1ab4424c248b49036bd (patch)
treeaf4d2a3bc5ecdd0b9c59619641d0aa46a19f72fd /src/main/java/com/google/devtools/build/lib
parent046a0bf9664f1e961669b8a8fbdc2e55c3cf0177 (diff)
Made j2objc translation flags accessible to Skylark, to migrate builds using
j2objc_library's --j2objc_translation_flags to future Skylark replacement rule. DELTA=42 (39 added, 0 deleted, 3 changed) DELTA_BY_EXTENSION=java=42 RELNOTES: None. PiperOrigin-RevId: 192838435
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib')
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/objc/J2ObjcConfiguration.java13
1 files changed, 9 insertions, 4 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/J2ObjcConfiguration.java b/src/main/java/com/google/devtools/build/lib/rules/objc/J2ObjcConfiguration.java
index 82ac947a8c..a096753189 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/objc/J2ObjcConfiguration.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/objc/J2ObjcConfiguration.java
@@ -28,10 +28,10 @@ import com.google.devtools.build.lib.concurrent.ThreadSafety.Immutable;
import com.google.devtools.build.lib.events.Event;
import com.google.devtools.build.lib.events.EventHandler;
import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec;
+import com.google.devtools.build.lib.skylarkinterface.SkylarkCallable;
import com.google.devtools.build.lib.skylarkinterface.SkylarkModule;
import com.google.devtools.build.lib.skylarkinterface.SkylarkModuleCategory;
import java.util.Collections;
-import java.util.List;
import javax.annotation.Nullable;
/**
@@ -96,7 +96,7 @@ public class J2ObjcConfiguration extends Fragment {
}
}
- private final List<String> translationFlags;
+ private final ImmutableList<String> translationFlags;
private final boolean removeDeadCode;
private final boolean experimentalJ2ObjcHeaderMap;
@Nullable private final Label deadCodeReport;
@@ -115,7 +115,7 @@ public class J2ObjcConfiguration extends Fragment {
@AutoCodec.Instantiator
J2ObjcConfiguration(
- List<String> translationFlags,
+ ImmutableList<String> translationFlags,
boolean removeDeadCode,
boolean experimentalJ2ObjcHeaderMap,
Label deadCodeReport) {
@@ -132,7 +132,12 @@ public class J2ObjcConfiguration extends Fragment {
* #J2OBJC_ALWAYS_ON_TRANSLATION_FLAGS}. The set of disallowed flags can be found at
* {@link #J2OBJC_BLACKLISTED_TRANSLATION_FLAGS}.
*/
- public Iterable<String> getTranslationFlags() {
+ @SkylarkCallable(
+ name = "translation_flags",
+ structField = true,
+ doc = "The list of flags to be used when the j2objc compiler is invoked. "
+ )
+ public ImmutableList<String> getTranslationFlags() {
return translationFlags;
}