diff options
| author |  asteinb <asteinb@google.com> | 2018-04-13 12:45:01 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-04-13 12:46:12 -0700 |
| commit | b7c367947d13ac88a526965e4c056fd0e4427d72 (patch) | |
| tree | 4be8280303abfe94ca14bd5e36e8cb4f465aef11 /src/main/java/com/google/devtools/build/lib | |
| parent | 445fb097b82aae3b2e5736aea540ecb907d5f052 (diff) | |
Remove value equality check for proguarding
ErrorProne has been complaining about this for a while, and unless there's
something incredibly clever going on that I'm missing (in which case we should
document it), using equals() should be just as effective.
RELNOTES: none
PiperOrigin-RevId: 192809127
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/rules/android/AndroidBinary.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidBinary.java b/src/main/java/com/google/devtools/build/lib/rules/android/AndroidBinary.java index 4c173780f5..b306d69fa8 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidBinary.java +++ b/src/main/java/com/google/devtools/build/lib/rules/android/AndroidBinary.java @@ -411,7 +411,7 @@ public abstract class AndroidBinary implements RuleConfiguredTargetFactory { if (AndroidCommon.getAndroidConfig(ruleContext).desugarJava8Libs() && dexPostprocessingOutput.classesDexZip().getFilename().endsWith(".zip")) { Artifact java8LegacyDex; - if (binaryJar == jarToDex) { + if (binaryJar.equals(jarToDex)) { // No Proguard: use canned Java 8 legacy .dex file java8LegacyDex = ruleContext.getPrerequisiteArtifact("$java8_legacy_dex", Mode.TARGET); |