Avoid autoboxing on potential hot paths in LineNumberTable

We wind up hitting this code path each time we call a user defined function
to calculate a pretty string for profiling purposes.

--
MOS_MIGRATED_REVID=109580385

1 files changed, 6 insertions, 2 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/syntax/LineNumberTable.java b/src/main/java/com/google/devtools/build/lib/syntax/LineNumberTable.java
index 5b7b395f1d..57ff2f9f5a 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/LineNumberTable.java
+++ b/src/main/java/com/google/devtools/build/lib/syntax/LineNumberTable.java
@@ -110,7 +110,9 @@ public abstract class LineNumberTable implements Serializable {
     }
 
     private int getLineAt(int offset) {
-      Preconditions.checkArgument(offset >= 0, "Illegal position: ", offset);
+      if (offset < 0) {
+        throw new IllegalStateException("Illegal position: " + offset);
+      }
       int lowBoundary = 1, highBoundary = linestart.length - 1;
       while (true) {
         if ((highBoundary - lowBoundary) <= 1) {
@@ -228,7 +230,9 @@ public abstract class LineNumberTable implements Serializable {
     }
 
     private SingleHashLine getHashLine(int offset) {
-      Preconditions.checkArgument(offset >= 0, "Illegal position: ", offset);
+      if (offset < 0) {
+        throw new IllegalStateException("Illegal position: " + offset);
+      }
       int binarySearchIndex = hashOrdering.binarySearch(
           table, new SingleHashLine(offset, -1, null));
       if (binarySearchIndex >= 0) {