diff options
author | Philipp Wollermann <philwo@google.com> | 2015-07-27 13:07:53 +0000 |
---|---|---|
committer | Damien Martin-Guillerez <dmarting@google.com> | 2015-07-27 16:34:01 +0000 |
commit | 72d50482ab196f2e4dff3b5845611204e378c8bf (patch) | |
tree | da74139482c8c04ab82504a21cd38d1037026b05 /src/main/java/com/google/devtools/build/lib | |
parent | 62a6d2542fd15e8d25e63e7359e59ead748b4e5c (diff) |
Remove a misleading comment in CppCompileAction (the class is not actually overriding getInputs()).
--
MOS_MIGRATED_REVID=99173247
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java index 4839a36388..bd959611c7 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java +++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java @@ -225,10 +225,8 @@ public class CppCompileAction extends AbstractAction implements IncludeScannable UUID actionClassId, boolean usePic, RuleContext ruleContext) { - // getInputs() method is overridden in this class so we pass a dummy empty - // list to the AbstractAction constructor in place of a real input collection. super(owner, - Artifact.NO_ARTIFACTS, + createInputs(mandatoryInputs, context.getCompilationPrerequisites(), optionalSourceFile), CollectionUtils.asListWithoutNulls(outputFile, dotdFile.artifact(), gcnoFile, dwoFile)); this.configuration = configuration; @@ -254,8 +252,6 @@ public class CppCompileAction extends AbstractAction implements IncludeScannable // We do not need to include the middleman artifact since it is a generated // artifact and will definitely exist prior to this action execution. this.mandatoryInputs = mandatoryInputs; - setInputs(createInputs(mandatoryInputs, context.getCompilationPrerequisites(), - optionalSourceFile)); verifyIncludePaths(ruleContext); } |