diff options
author | 2017-02-23 19:37:47 +0000 | |
---|---|---|
committer | 2017-02-24 08:29:54 +0000 | |
commit | 6731efe77088cb054cc595449888a6eccab397a4 (patch) | |
tree | 4249e54fb57d836e2210f198e46660de098880b8 /src/main/java/com/google/devtools/build/lib | |
parent | 5e9e1949f4c08ce09665b92aadf7ec7e518aab6a (diff) |
All objc linking rules get the crosstool.
--
PiperOrigin-RevId: 148369723
MOS_MIGRATED_REVID=148369723
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib')
8 files changed, 14 insertions, 11 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/AppleWatchExtensionBinaryRule.java b/src/main/java/com/google/devtools/build/lib/rules/objc/AppleWatchExtensionBinaryRule.java index 05b3479c3b..bb268b5b7a 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/AppleWatchExtensionBinaryRule.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/AppleWatchExtensionBinaryRule.java @@ -20,6 +20,7 @@ import com.google.devtools.build.lib.analysis.RuleDefinitionEnvironment; import com.google.devtools.build.lib.packages.RuleClass; import com.google.devtools.build.lib.packages.RuleClass.Builder; import com.google.devtools.build.lib.rules.apple.AppleConfiguration; +import com.google.devtools.build.lib.rules.cpp.CppConfiguration; /** * Rule definition for apple_watch_extension_binary. @@ -29,7 +30,7 @@ public class AppleWatchExtensionBinaryRule implements RuleDefinition { public RuleClass build(Builder builder, RuleDefinitionEnvironment env) { return builder .requiresConfigurationFragments(ObjcConfiguration.class, J2ObjcConfiguration.class, - AppleConfiguration.class) + AppleConfiguration.class, CppConfiguration.class) /*<!-- #BLAZE_RULE(apple_watch_extension_binary).IMPLICIT_OUTPUTS --> <ul> <li><code><var>name</var>.xcodeproj/project.pbxproj</code>: An Xcode project file which diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/ExperimentalObjcLibraryRule.java b/src/main/java/com/google/devtools/build/lib/rules/objc/ExperimentalObjcLibraryRule.java index 82612bc702..233692dd28 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/ExperimentalObjcLibraryRule.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/ExperimentalObjcLibraryRule.java @@ -48,8 +48,7 @@ public class ExperimentalObjcLibraryRule implements RuleDefinition { BaseRuleClasses.BaseRule.class, ObjcRuleClasses.LinkingRule.class, ObjcRuleClasses.AlwaysLinkRule.class, - ObjcRuleClasses.XcodegenRule.class, - ObjcRuleClasses.CrosstoolRule.class) + ObjcRuleClasses.XcodegenRule.class) .build(); } } diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/IosExtensionBinaryRule.java b/src/main/java/com/google/devtools/build/lib/rules/objc/IosExtensionBinaryRule.java index 4e38654348..b4a8afa798 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/IosExtensionBinaryRule.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/IosExtensionBinaryRule.java @@ -20,6 +20,7 @@ import com.google.devtools.build.lib.analysis.RuleDefinitionEnvironment; import com.google.devtools.build.lib.packages.RuleClass; import com.google.devtools.build.lib.packages.RuleClass.Builder; import com.google.devtools.build.lib.rules.apple.AppleConfiguration; +import com.google.devtools.build.lib.rules.cpp.CppConfiguration; /** * Rule definition for ios_extension_binary. @@ -29,7 +30,7 @@ public class IosExtensionBinaryRule implements RuleDefinition { public RuleClass build(Builder builder, RuleDefinitionEnvironment env) { return builder .requiresConfigurationFragments(ObjcConfiguration.class, J2ObjcConfiguration.class, - AppleConfiguration.class) + AppleConfiguration.class, CppConfiguration.class) /*<!-- #BLAZE_RULE(ios_extension_binary).IMPLICIT_OUTPUTS --> <ul> <li><code><var>name</var>.xcodeproj/project.pbxproj</code>: An Xcode project file which diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/IosFrameworkBinaryRule.java b/src/main/java/com/google/devtools/build/lib/rules/objc/IosFrameworkBinaryRule.java index 209d53ef40..6f19e712d2 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/IosFrameworkBinaryRule.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/IosFrameworkBinaryRule.java @@ -20,6 +20,7 @@ import com.google.devtools.build.lib.analysis.RuleDefinitionEnvironment; import com.google.devtools.build.lib.packages.RuleClass; import com.google.devtools.build.lib.packages.RuleClass.Builder; import com.google.devtools.build.lib.rules.apple.AppleConfiguration; +import com.google.devtools.build.lib.rules.cpp.CppConfiguration; /** * Rule definition for ios_framework_binary. @@ -30,7 +31,7 @@ public class IosFrameworkBinaryRule implements RuleDefinition { public RuleClass build(Builder builder, RuleDefinitionEnvironment environment) { return builder .requiresConfigurationFragments(ObjcConfiguration.class, J2ObjcConfiguration.class, - AppleConfiguration.class) + AppleConfiguration.class, CppConfiguration.class) /*<!-- #BLAZE_RULE(ios_framework_binary).IMPLICIT_OUTPUTS --> <ul> <li><code><var>name</var>.xcodeproj/project.pbxproj</code>: An Xcode project file which diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/IosTestRule.java b/src/main/java/com/google/devtools/build/lib/rules/objc/IosTestRule.java index f39288af22..cd93bb721b 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/IosTestRule.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/IosTestRule.java @@ -36,6 +36,7 @@ import com.google.devtools.build.lib.packages.Rule; import com.google.devtools.build.lib.packages.RuleClass; import com.google.devtools.build.lib.packages.RuleClass.Builder.RuleClassType; import com.google.devtools.build.lib.rules.apple.AppleConfiguration; +import com.google.devtools.build.lib.rules.cpp.CppConfiguration; import com.google.devtools.build.lib.rules.objc.ObjcRuleClasses.BundlingRule; import com.google.devtools.build.lib.syntax.Type; import com.google.devtools.build.lib.util.FileType; @@ -50,7 +51,8 @@ public class IosTestRule implements RuleDefinition { final Label mcov = env.getToolsLabel("//tools/objc:mcov"); return builder .requiresConfigurationFragments( - ObjcConfiguration.class, J2ObjcConfiguration.class, AppleConfiguration.class) + ObjcConfiguration.class, J2ObjcConfiguration.class, AppleConfiguration.class, + CppConfiguration.class) /*<!-- #BLAZE_RULE(ios_test).IMPLICIT_OUTPUTS --> <ul> <li><code><var>name</var>.ipa</code>: the test bundle as an diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcBinaryRule.java b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcBinaryRule.java index af198018f2..c660f04923 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcBinaryRule.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcBinaryRule.java @@ -75,8 +75,7 @@ public class ObjcBinaryRule implements RuleDefinition { ObjcRuleClasses.LinkingRule.class, ObjcRuleClasses.XcodegenRule.class, ObjcRuleClasses.ReleaseBundlingRule.class, - ObjcRuleClasses.SimulatorRule.class, - ObjcRuleClasses.CrosstoolRule.class) + ObjcRuleClasses.SimulatorRule.class) .build(); } } diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcLibraryRule.java b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcLibraryRule.java index 650bb1c2a4..8dc41b2faf 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcLibraryRule.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcLibraryRule.java @@ -53,8 +53,7 @@ public class ObjcLibraryRule implements RuleDefinition { .name("objc_library") .factoryClass(ObjcLibrary.class) .ancestors(BaseRuleClasses.BaseRule.class, ObjcRuleClasses.CompilingRule.class, - ObjcRuleClasses.CrosstoolRule.class, ObjcRuleClasses.AlwaysLinkRule.class, - ObjcRuleClasses.XcodegenRule.class) + ObjcRuleClasses.AlwaysLinkRule.class, ObjcRuleClasses.XcodegenRule.class) .build(); } } diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcRuleClasses.java b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcRuleClasses.java index 3d848b897f..80ea4c0a4d 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcRuleClasses.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcRuleClasses.java @@ -776,7 +776,8 @@ public class ObjcRuleClasses { CompileDependencyRule.class, CoptsRule.class, LibtoolRule.class, - XcrunRule.class) + XcrunRule.class, + CrosstoolRule.class) .build(); } } |