aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib
diff options
context:
space:
mode:
authorGravatar shreyax <shreyax@google.com>2017-09-11 21:11:13 +0200
committerGravatar Philipp Wollermann <philwo@google.com>2017-09-12 14:05:19 +0200
commit4c4ce713c57d6b8850f6966be66567da194e4c25 (patch)
tree6df7d16e5a39ebe4b2560e1f70b795bf318be827 /src/main/java/com/google/devtools/build/lib
parent3f5590fc94cebd593e80db09e8c6c3267a11cda1 (diff)
Drive-by clean-up: Make it slightly more obvious that one of the PackageFunction constructors is only used in tests and annotate the missing variable.
RELNOTES: None. PiperOrigin-RevId: 168265593
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib')
-rw-r--r--src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java
index d47c902ff6..562b2bfdb7 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java
@@ -13,6 +13,7 @@
// limitations under the License.
package com.google.devtools.build.lib.skyframe;
+import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.Throwables;
import com.google.common.cache.Cache;
import com.google.common.collect.ImmutableCollection;
@@ -132,6 +133,7 @@ public class PackageFunction implements SkyFunction {
this.actionOnIOExceptionReadingBuildFile = actionOnIOExceptionReadingBuildFile;
}
+ @VisibleForTesting
public PackageFunction(
PackageFactory packageFactory,
CachingPackageLocator pkgLocator,
@@ -148,7 +150,7 @@ public class PackageFunction implements SkyFunction {
astCache,
numPackagesLoaded,
skylarkImportLookupFunctionForInlining,
- null,
+ /*packageProgress=*/ null,
ActionOnIOExceptionReadingBuildFile.UseOriginalIOException.INSTANCE);
}