diff options
| author |  Akira Baruah <akira.baruah@gmail.com> | 2017-10-11 11:32:50 +0200 |
|---|---|---|
| committer |  Marcel Hlopko <hlopko@google.com> | 2017-10-11 13:57:44 +0200 |
| commit | 0a63dadf4eafbae1730f88644b0c537fb1c16d5c (patch) | |
| tree | 48a05dc9bb3b90c75695f642d212a58bb5f665c2 /src/main/java/com/google/devtools/build/lib | |
| parent | 8e04f24517feb48024f21aa2cf672550463107cf (diff) | |
Properly escape GitHub repository download URL for git_repository w/ sha256
Addresses #3661
Closes #3770.
PiperOrigin-RevId: 171797773
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/bazel/repository/GitCloner.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/repository/GitCloner.java b/src/main/java/com/google/devtools/build/lib/bazel/repository/GitCloner.java index 16aafc7c62..5c3a0832ba 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/repository/GitCloner.java +++ b/src/main/java/com/google/devtools/build/lib/bazel/repository/GitCloner.java @@ -291,8 +291,8 @@ public class GitCloner { String repositoryName = matcher.group(2); String downloadUrl = "https://github.com/" - + UrlEscapers.urlPathSegmentEscaper().escape( - user + "/" + repositoryName + "/archive/" + descriptor.ref + ".tar.gz"); + + UrlEscapers.urlFragmentEscaper() + .escape(user + "/" + repositoryName + "/archive/" + descriptor.ref + ".tar.gz"); try { FileSystemUtils.createDirectoryAndParents(descriptor.directory); Path tgz = downloader.download(ImmutableList.of(new URL(downloadUrl)), uncheckedSha256, |