diff options
| author |  ulfjack <ulfjack@google.com> | 2017-07-07 07:13:00 -0400 |
|---|---|---|
| committer |  John Cater <jcater@google.com> | 2017-07-07 13:37:11 -0400 |
| commit | 6ee07397d48b3c2c5484e42408fdd721277d2ce2 (patch) | |
| tree | ba67a909c1fd9fb1075cfe039da1f7b7965f271d /src/main/java/com/google/devtools/build/lib/worker | |
| parent | 9e54088754a8fbe1b73c02e7e25e8f46c44bc7d5 (diff) | |
Cache flaky tests (remove the cachable flag from test result data)
The cachable flag was only set to false for flaky tests.
Before this CL, we did not cache flaky tests on subsequent runs, instead
rerunning them, even though this is both very expensive and inconsistent with
our normal handling, which is to cache passes but not errors.
If cache_test_results is enabled, we now also cached timed out test results.
If cache_test_results=auto (the default), we now also cache flaky tests.
We still do not cache failed tests; the TestRunnerAction checks if the previous
test result was marked as passed (which also applies to flaky tests, but not
to failed or timed-out tests).
Also add some unit tests.
PiperOrigin-RevId: 161187950
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/worker')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/worker/WorkerTestStrategy.java | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/worker/WorkerTestStrategy.java b/src/main/java/com/google/devtools/build/lib/worker/WorkerTestStrategy.java index 6fd225e4bd..1b3c451a16 100644 --- a/src/main/java/com/google/devtools/build/lib/worker/WorkerTestStrategy.java +++ b/src/main/java/com/google/devtools/build/lib/worker/WorkerTestStrategy.java @@ -192,7 +192,6 @@ public class WorkerTestStrategy extends StandaloneTestStrategy { builder .setTestPassed(true) .setStatus(BlazeTestStatus.PASSED) - .setCachable(true) .setPassedLog(testLogPath.getPathString()); } else { builder |