Automated rollback of commit 7e87730de985b7099b9b683571d58efdaab70890.

*** Reason for rollback ***

Go back to the default constructor - instead of requiring everywhere to know the correct hash function, we'll have the default rely on global state. It will make transition easier, even if it makes the origin of the hash less obvious.

*** Original change description ***

Remove default MD5 in most of Bazel's virtual filesystems.

This forces the ex-default to be explicit in a lot of tests, but I'd rather that than have the risk of implicit md5-use in production code.

To keep this CL smaller, do not remove the default from UnixFS quite yet.

RELNOTES: None.
PiperOrigin-RevId: 206358838

1 files changed, 2 insertions, 3 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/vfs/JavaIoFileSystem.java b/src/main/java/com/google/devtools/build/lib/vfs/JavaIoFileSystem.java
index 00a320fa57..1fec03f5db 100644
--- a/src/main/java/com/google/devtools/build/lib/vfs/JavaIoFileSystem.java
+++ b/src/main/java/com/google/devtools/build/lib/vfs/JavaIoFileSystem.java
@@ -53,7 +53,7 @@ public class JavaIoFileSystem extends AbstractFileSystemWithCustomStat {
   protected static final String ERR_NOT_A_DIRECTORY = " (Not a directory)";
 
   public JavaIoFileSystem() {
-    this(new JavaClock(), DigestHashFunction.MD5);
+    this(new JavaClock());
   }
 
   public JavaIoFileSystem(DigestHashFunction hashFunction) {
@@ -62,8 +62,7 @@ public class JavaIoFileSystem extends AbstractFileSystemWithCustomStat {
   }
 
   @VisibleForTesting
-  JavaIoFileSystem(Clock clock, DigestHashFunction hashFunction) {
-    super(hashFunction);
+  JavaIoFileSystem(Clock clock) {
     this.clock = clock;
   }