diff options
| author |  tomlu <tomlu@google.com> | 2017-12-22 00:56:58 -0800 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2017-12-22 00:58:31 -0800 |
| commit | e63a867feb2483851b5169894ff7b3c0bdb26581 (patch) | |
| tree | 68306264ab9dc8f2383f987a42fb768b2d6436a8 /src/main/java/com/google/devtools/build/lib/vfs/BUILD | |
| parent | 85e8d51c72c5dcb4d1f6a8f3186149339ca59fac (diff) | |
Redo FileType to reduce generated garbage.
* Change FileType to no longer assume it operates on just the base name (it can now be given a full path).
* Move the responsibility to specific classes (Artifact, Path, PathFragment) to decide how they want to offer up a string that includes the file name.
* Flip the order in which users are expected to check Artifact type, from FileType#matches(Artifact) to Artifact#isFileType(FileType). This looks natural and should encourage developers to use efficient file type checking methods.
* Change CppCompileAction to use the new API.
RELNOTES: None
PiperOrigin-RevId: 179903239
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/vfs/BUILD')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/vfs/BUILD | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/vfs/BUILD b/src/main/java/com/google/devtools/build/lib/vfs/BUILD index 88c7c86490..f6d2eb427b 100644 --- a/src/main/java/com/google/devtools/build/lib/vfs/BUILD +++ b/src/main/java/com/google/devtools/build/lib/vfs/BUILD @@ -19,6 +19,7 @@ java_library( srcs = PATH_FRAGMENT_SOURCES, deps = [ "//src/main/java/com/google/devtools/build/lib:base-util", + "//src/main/java/com/google/devtools/build/lib:filetype", "//src/main/java/com/google/devtools/build/lib:os_util", "//src/main/java/com/google/devtools/build/lib:skylarkinterface", "//src/main/java/com/google/devtools/build/lib/concurrent", @@ -44,6 +45,7 @@ java_library( deps = [ ":pathfragment", "//src/main/java/com/google/devtools/build/lib:base-util", + "//src/main/java/com/google/devtools/build/lib:filetype", "//src/main/java/com/google/devtools/build/lib:os_util", "//src/main/java/com/google/devtools/build/lib:skylarkinterface", "//src/main/java/com/google/devtools/build/lib/clock", |