Remove synchronization from file system.

After the path refactor we will no longer have path instances to synchronize on.

The underlying OS file systems are already naturally thread safe, that is, their internal data structures cannot be damaged. Any further synchronization (eg. races between directory creation and deletion) has to be managed at the client level.

The last attempt to do this failed because of races in FileUtils#createDirectoryAndParents on Windows. This method is now gone, replaced by a method from the Java framework that knows how to synchronize.

PiperOrigin-RevId: 180290901

1 files changed, 9 insertions, 11 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/vfs/AbstractFileSystem.java b/src/main/java/com/google/devtools/build/lib/vfs/AbstractFileSystem.java
index 743bf37dd0..4d47205843 100644
--- a/src/main/java/com/google/devtools/build/lib/vfs/AbstractFileSystem.java
+++ b/src/main/java/com/google/devtools/build/lib/vfs/AbstractFileSystem.java
@@ -96,18 +96,16 @@ abstract class AbstractFileSystem extends FileSystem {
 
   @Override
   protected OutputStream getOutputStream(Path path, boolean append) throws IOException {
-    synchronized (path) {
-      try {
-        return createFileOutputStream(path, append);
-      } catch (FileNotFoundException e) {
-        // Why does it throw a *FileNotFoundException* if it can't write?
-        // That does not make any sense! And its in a completely different
-        // format than in other situations, no less!
-        if (e.getMessage().equals(path + ERR_PERMISSION_DENIED)) {
-          throw new FileAccessException(e.getMessage());
-        }
-        throw e;
+    try {
+      return createFileOutputStream(path, append);
+    } catch (FileNotFoundException e) {
+      // Why does it throw a *FileNotFoundException* if it can't write?
+      // That does not make any sense! And its in a completely different
+      // format than in other situations, no less!
+      if (e.getMessage().equals(path + ERR_PERMISSION_DENIED)) {
+        throw new FileAccessException(e.getMessage());
       }
+      throw e;
     }
   }