Avoid auto-unboxing in Preconditions check that has string then two integer arguments (seems too messy for a family of functions).

--
MOS_MIGRATED_REVID=112472644

1 files changed, 9 insertions, 3 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/syntax/BuiltinFunction.java b/src/main/java/com/google/devtools/build/lib/syntax/BuiltinFunction.java
index eb28b68fbb..6cbbf2363a 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/BuiltinFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/syntax/BuiltinFunction.java
@@ -248,9 +248,15 @@ public class BuiltinFunction extends BaseFunction {
     int arguments = signature.getSignature().getShape().getArguments();
     innerArgumentCount = arguments + (extraArgs == null ? 0 : extraArgs.length);
     Class<?>[] parameterTypes = invokeMethod.getParameterTypes();
-    Preconditions.checkArgument(innerArgumentCount == parameterTypes.length,
-        "bad argument count for %s: method has %s arguments, type list has %s",
-        getName(), innerArgumentCount, parameterTypes.length);
+    if (innerArgumentCount != parameterTypes.length) {
+      // Guard message construction by check to avoid autoboxing two integers.
+      throw new IllegalStateException(
+          String.format(
+              "bad argument count for %s: method has %s arguments, type list has %s",
+              getName(),
+              innerArgumentCount,
+              parameterTypes.length));
+    }
 
     if (enforcedArgumentTypes != null) {
       for (int i = 0; i < arguments; i++) {