Raise error if we find an unknown type in native.rule().

Handle more types:

* Boolean
* TriState
* SkylarkValue (eg. FileSetEntry)
* skip Licenses, Distribs.

--
MOS_MIGRATED_REVID=112690550

1 files changed, 19 insertions, 5 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/syntax/BuiltinFunction.java b/src/main/java/com/google/devtools/build/lib/syntax/BuiltinFunction.java
index 6cbbf2363a..74a9f4c2bc 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/BuiltinFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/syntax/BuiltinFunction.java
@@ -198,18 +198,32 @@ public class BuiltinFunction extends BaseFunction {
     }
   }
 
+  private static String stacktraceToString(StackTraceElement[] elts) {
+    StringBuilder b = new StringBuilder();
+    for (StackTraceElement e : elts) {
+      b.append(e.toString());
+      b.append("\n");
+    }
+    return b.toString();
+  }
+
   private IllegalStateException badCallException(Location loc, Throwable e, Object... args) {
     // If this happens, it's a bug in our code.
-    return new IllegalStateException(String.format("%s%s (%s)\n"
-            + "while calling %s with args %s\nJava parameter types: %s\nSkylark type checks: %s",
+    return new IllegalStateException(
+        String.format(
+            "%s%s (%s)\n"
+                + "while calling %s with args %s\n"
+                + "Java parameter types: %s\nSkylark type checks: %s",
             (loc == null) ? "" : loc + ": ",
-            e.getClass().getName(), e.getMessage(), this,
             Arrays.asList(args),
+            e.getClass().getName(),
+            stacktraceToString(e.getStackTrace()),
+            this,
             Arrays.asList(invokeMethod.getParameterTypes()),
-            signature.getTypes()), e);
+            signature.getTypes()),
+        e);
   }
 
-
   /** Configure the reflection mechanism */
   @Override
   public void configure(SkylarkSignature annotation) {