diff options
| author |  brandjon <brandjon@google.com> | 2017-07-11 21:43:28 +0200 |
|---|---|---|
| committer |  László Csomor <laszlocsomor@google.com> | 2017-07-12 08:49:58 +0200 |
| commit | 3b038b9f7657f2d4c77700964ca06d92b3a6db12 (patch) | |
| tree | 35ce4eeed92225f600744c1f758221760f34ae01 /src/main/java/com/google/devtools/build/lib/syntax | |
| parent | befb8d62100dddffb513b6378f69a3fec10c7dd3 (diff) | |
Automated rollback of commit 0d2aa6369b09940d584b544fb10796387e0fafa0.
*** Reason for rollback ***
PiperOrigin-RevId: 161567104
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/syntax')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/syntax/Printer.java | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/syntax/Printer.java b/src/main/java/com/google/devtools/build/lib/syntax/Printer.java index b91237ad72..3a6c60d7e0 100644 --- a/src/main/java/com/google/devtools/build/lib/syntax/Printer.java +++ b/src/main/java/com/google/devtools/build/lib/syntax/Printer.java @@ -387,10 +387,8 @@ public class Printer { this.append(o.toString()); } else { - // Other types of objects shouldn't be leaked to Skylark, but if happens, their - // .toString method shouldn't be used because their return values are likely to contain - // memory addresses or other nondeterministic information. - this.append("<unknown object " + o.getClass().getName() + ">"); + // TODO(bazel-team): change to a special representation for unknown objects + this.append(o.toString()); } return this; |