aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/syntax
diff options
context:
space:
mode:
authorGravatar Googler <noreply@google.com>2015-03-03 09:44:18 +0000
committerGravatar Ulf Adams <ulfjack@google.com>2015-03-05 14:22:33 +0000
commit05a0494a7f151d514cfa3050587220a2cffaf55b (patch)
tree153bf016c38d37bcbb8b73b601c778187a058792 /src/main/java/com/google/devtools/build/lib/syntax
parent2cbac1f35f263480b8f42743c02d2b29e0e87f0a (diff)
Skylark: 'enumerate' function is fixed (see the extra check in MethodLibraryTest#testEnumerate), it returns a SkylarkList of tuples.
MethodLibrary tests are cleaned up. -- MOS_MIGRATED_REVID=87592639
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/syntax')
-rw-r--r--src/main/java/com/google/devtools/build/lib/syntax/SkylarkFunction.java2
-rw-r--r--src/main/java/com/google/devtools/build/lib/syntax/SkylarkList.java2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkFunction.java b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkFunction.java
index ecfd660c48..6a1aadf78c 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkFunction.java
@@ -300,7 +300,7 @@ public abstract class SkylarkFunction extends AbstractFunction {
return type.cast(elem);
} catch (ClassCastException e) {
throw new EvalException(loc, String.format("expected %s for '%s' but got %s instead",
- type.getSimpleName(), what, EvalUtils.getDataTypeName(elem)));
+ EvalUtils.getDataTypeNameFromClass(type), what, EvalUtils.getDataTypeName(elem)));
}
}
}
diff --git a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkList.java b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkList.java
index 4e25b771b0..9e9788a1d4 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkList.java
+++ b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkList.java
@@ -353,7 +353,7 @@ public abstract class SkylarkList implements Iterable<Object> {
/**
* @param elements the contents of the list
* @return a Skylark list containing elements
- * @throws an EvalException in case the list is not monomorphic
+ * @throws EvalException in case the list is not monomorphic
*/
public static SkylarkList list(Collection<?> elements, Location loc) throws EvalException {
if (elements.isEmpty()) {