diff options
| author |  janakr <janakr@google.com> | 2018-03-03 11:12:36 -0800 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-03-03 11:14:47 -0800 |
| commit | 76de1ad3af6297cbc7c34054dd4340e02750a712 (patch) | |
| tree | b68a171ae3c13de3c92b7a3c7d8b293ce4647a4d /src/main/java/com/google/devtools/build/lib/syntax/FuncallExpression.java | |
| parent | d5f374ce5caea11a0a760f121e1e75e68f107dab (diff) | |
Get rid of almost all Skylark codecs. We need to introduce a wrapper to turn ObjectCodec into a MEMOIZE_AFTER MemoizingCodec. I think that this is safe, because all the codecs that are being wrapped this way weren't memoizing anything internally that I could see.
In order to @AutoCodec the WithValue type, which is generic and can have null elements in lists, add functionality to @AutoCodec to deal with generic type static instantiators, matching generic type arguments (although I'm not sure why that wasn't already working), and null elements in lists.
PiperOrigin-RevId: 187740461
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/syntax/FuncallExpression.java')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/syntax/FuncallExpression.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/syntax/FuncallExpression.java b/src/main/java/com/google/devtools/build/lib/syntax/FuncallExpression.java index 68e5006ead..2639c2735d 100644 --- a/src/main/java/com/google/devtools/build/lib/syntax/FuncallExpression.java +++ b/src/main/java/com/google/devtools/build/lib/syntax/FuncallExpression.java @@ -26,6 +26,7 @@ import com.google.common.collect.ImmutableSortedMap; import com.google.common.collect.Iterables; import com.google.common.collect.Lists; import com.google.devtools.build.lib.events.Location; +import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec; import com.google.devtools.build.lib.skylarkinterface.Param; import com.google.devtools.build.lib.skylarkinterface.ParamType; import com.google.devtools.build.lib.skylarkinterface.SkylarkCallable; @@ -52,9 +53,8 @@ import java.util.concurrent.ExecutionException; import java.util.stream.Collectors; import javax.annotation.Nullable; -/** - * Syntax node for a function call expression. - */ +/** Syntax node for a function call expression. */ +@AutoCodec public final class FuncallExpression extends Expression { /** |