diff options
| author |  ccalvarin <ccalvarin@google.com> | 2017-06-27 17:58:35 +0200 |
|---|---|---|
| committer |  Marcel Hlopko <hlopko@google.com> | 2017-06-28 10:17:40 +0200 |
| commit | 3bc1547a5cd78bd6639d968b3cfddbe26b1c31d5 (patch) | |
| tree | ad80da2596d9150632ca6a1f1510060fe849fa3a /src/main/java/com/google/devtools/build/lib/ssd | |
| parent | 9b394a24dc65c794242e98a8a41eb8a60c78367b (diff) | |
Add the default category and tag to all options.
Move the default from the annotation to every mention. This makes the incompleteness explicit. Will add the defaults to test targets in a separate change.
Once all dependencies are cleaned up, the Option annotation will no longer allow options without the documentationCategory or effectTag, to prevent new options being added without categories while we migrate to the new option categorization.
PiperOrigin-RevId: 160281252
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/ssd')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/ssd/BUILD | 1 | ||||
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/ssd/SsdOptions.java | 4 |
2 files changed, 5 insertions, 0 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/ssd/BUILD b/src/main/java/com/google/devtools/build/lib/ssd/BUILD index fa77e290f4..78035e86c8 100644 --- a/src/main/java/com/google/devtools/build/lib/ssd/BUILD +++ b/src/main/java/com/google/devtools/build/lib/ssd/BUILD @@ -9,6 +9,7 @@ java_library( "//src/main/java/com/google/devtools/build/lib:runtime", "//src/main/java/com/google/devtools/build/lib/actions", "//src/main/java/com/google/devtools/common/options", + "//src/main/protobuf:option_filters_java_proto", "//third_party:guava", ], ) diff --git a/src/main/java/com/google/devtools/build/lib/ssd/SsdOptions.java b/src/main/java/com/google/devtools/build/lib/ssd/SsdOptions.java index a9da284f24..d75c628a89 100644 --- a/src/main/java/com/google/devtools/build/lib/ssd/SsdOptions.java +++ b/src/main/java/com/google/devtools/build/lib/ssd/SsdOptions.java @@ -14,7 +14,9 @@ package com.google.devtools.build.lib.ssd; import com.google.devtools.common.options.Option; +import com.google.devtools.common.options.OptionDocumentationCategory; import com.google.devtools.common.options.OptionsBase; +import com.google.devtools.common.options.proto.OptionFilters.OptionEffectTag; /** * Options that tune Bazel's performance in order to increase performance on workstations with an @@ -24,6 +26,8 @@ public class SsdOptions extends OptionsBase { @Option( name = "experimental_multi_threaded_digest", defaultValue = "false", + documentationCategory = OptionDocumentationCategory.UNCATEGORIZED, + effectTags = {OptionEffectTag.UNKNOWN}, help = "Whether to always compute MD5 digests of files with multiple threads. Might improve " + "performance when using an SSD." |