diff options
author | Klaus Aehlig <aehlig@google.com> | 2017-06-09 14:03:19 -0400 |
---|---|---|
committer | John Cater <jcater@google.com> | 2017-06-09 14:07:39 -0400 |
commit | 68028317c1d3d831a24f90e2b25d1410ce045c54 (patch) | |
tree | 45429403249a32f071a9fa89cff7b2c6dde72b40 /src/main/java/com/google/devtools/build/lib/skylarkinterface | |
parent | b6ea82af51cac711b13c5a483f92d178df60b08a (diff) |
experimental UI: move stopUpdateThread() out of synchronized, again
The experimental UI uses a thread to regularly update itself to reflect time-based
changes. As that that thread has to call synchronized methods any waiting for it to
finish has to happen outside any synchronized block. Unfortunately, 9e0308e0f7 accidentally
moved the stopUpdateThread() in buildComplete() into the synchronized block, thus giving
an opportunity for deadlocks. Move it out again.
Also, as the accounting for pending transports now happens in synchronized methods in
the state tracker, the buildEventTransportClosed() method does not have to be synchronized
any more---thus eliminating the second deadlock opportunity.
Change-Id: Icacb2ee70f4bedde1c1aac2bcfefc6fabf42fdd3
PiperOrigin-RevId: 158537844
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skylarkinterface')
0 files changed, 0 insertions, 0 deletions