aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/skylarkdebug
diff options
context:
space:
mode:
authorGravatar brendandouglas <brendandouglas@google.com>2018-06-13 14:27:08 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-06-13 14:28:27 -0700
commite3f29ad4e03c6ff504eb474607f8d92d1f7ee89b (patch)
tree47c197d1e7ba8b4e4c37b72f8b715771b6364ff8 /src/main/java/com/google/devtools/build/lib/skylarkdebug
parent07b2ea405c1ee3b70d3dea153338f897ba522ee0 (diff)
Skylark debugger: don't quote or escape strings when serializing.
A minor serialization improvement. I'm planning to refactor this code significantly, but wanted to get this in before I forgot. PiperOrigin-RevId: 200453925
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skylarkdebug')
-rw-r--r--src/main/java/com/google/devtools/build/lib/skylarkdebug/server/DebuggerSerialization.java9
1 files changed, 8 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skylarkdebug/server/DebuggerSerialization.java b/src/main/java/com/google/devtools/build/lib/skylarkdebug/server/DebuggerSerialization.java
index 70d716332a..e45a1fa294 100644
--- a/src/main/java/com/google/devtools/build/lib/skylarkdebug/server/DebuggerSerialization.java
+++ b/src/main/java/com/google/devtools/build/lib/skylarkdebug/server/DebuggerSerialization.java
@@ -36,11 +36,18 @@ final class DebuggerSerialization {
.setLabel(label)
// TODO(bazel-team): omit type details for non-Skylark values
.setType(EvalUtils.getDataTypeName(value))
- .setDescription(Printer.repr(value))
+ .setDescription(getDescription(value))
.addAllChild(getChildren(value))
.build();
}
+ private static String getDescription(Object value) {
+ if (value instanceof String) {
+ return (String) value;
+ }
+ return Printer.repr(value);
+ }
+
private static Value errorValue(String errorMessage) {
return Value.newBuilder().setLabel("Error").setDescription(errorMessage).build();
}