aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/skylarkdebug
diff options
context:
space:
mode:
authorGravatar allevato <allevato@google.com>2017-10-19 21:05:24 +0200
committerGravatar Damien Martin-Guillerez <dmarting@google.com>2017-10-20 14:04:05 +0200
commitcc519a047821d7e48b642d95ee6f7dfe2350bed8 (patch)
tree9830e28b98b08fb5b48f8e7b606221446783f4a3 /src/main/java/com/google/devtools/build/lib/skylarkdebug
parent1e65fee5b3f306db2cc3babc370a0b9dd2bb800d (diff)
Change "LexicalBlock" back to "Scope".
The former is *technically* more formally correct, but other debuggers (VS Code and V8, among others) already use the term "scope" to refer to the same concept so aligning with those existing debuggers has value. PiperOrigin-RevId: 172778821
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skylarkdebug')
-rw-r--r--src/main/java/com/google/devtools/build/lib/skylarkdebug/proto/skylark_debugging.proto22
1 files changed, 11 insertions, 11 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skylarkdebug/proto/skylark_debugging.proto b/src/main/java/com/google/devtools/build/lib/skylarkdebug/proto/skylark_debugging.proto
index cde317ac78..591eb5512a 100644
--- a/src/main/java/com/google/devtools/build/lib/skylarkdebug/proto/skylark_debugging.proto
+++ b/src/main/java/com/google/devtools/build/lib/skylarkdebug/proto/skylark_debugging.proto
@@ -175,22 +175,13 @@ message Frame {
// The name of the function that this frame represents.
string function_name = 1;
- // The lexical blocks that contain value bindings accessible in this frame.
- repeated LexicalBlock lexical_block = 2;
+ // The scopes that contain value bindings accessible in this frame.
+ repeated Scope scope = 2;
// The source location where the frame is currently paused.
Location location = 3;
}
-// A lexical block that contains value bindings accessible in a frame.
-message LexicalBlock {
- // A human-readable name of the lexical block, such as "global" or "local".
- string name = 1;
-
- // The variable bindings that are defined in this lexical block.
- repeated Value binding = 2;
-}
-
// A location in Skylark source code.
message Location {
// The path of the Skylark source file.
@@ -200,6 +191,15 @@ message Location {
uint32 line_number = 2;
}
+// A scope that contains value bindings accessible in a frame.
+message Scope {
+ // A human-readable name of the scope, such as "global" or "local".
+ string name = 1;
+
+ // The variable bindings that are defined in this scope.
+ repeated Value binding = 2;
+}
+
// Describes the stepping behavior that should occur when execution of a thread
// is continued.
enum Stepping {