diff options
author | Damien Martin-Guillerez <dmarting@google.com> | 2016-02-05 22:32:08 +0000 |
---|---|---|
committer | David Chen <dzc@google.com> | 2016-02-07 11:33:27 +0000 |
commit | 5e95a46074fa011461f58cb04521e4b7c2a5f3d5 (patch) | |
tree | b5f601749a3bb0efd6e07a30d1965628c82f7805 /src/main/java/com/google/devtools/build/lib/skyframe | |
parent | bc8b5e09ff667c7d0bf7186a7a207629e6d7bad5 (diff) |
WorkspaceASTFunction returns a list of ASTs so we can split the AST before load statements
Issue #824 Step 2.
--
MOS_MIGRATED_REVID=113986176
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe')
3 files changed, 72 insertions, 18 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/WorkspaceASTFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/WorkspaceASTFunction.java index d1077d2260..46f5d0d9d1 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/WorkspaceASTFunction.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/WorkspaceASTFunction.java @@ -14,9 +14,12 @@ package com.google.devtools.build.lib.skyframe; +import com.google.common.collect.ImmutableList; import com.google.devtools.build.lib.packages.RuleClassProvider; import com.google.devtools.build.lib.syntax.BuildFileAST; +import com.google.devtools.build.lib.syntax.LoadStatement; import com.google.devtools.build.lib.syntax.ParserInputSource; +import com.google.devtools.build.lib.syntax.Statement; import com.google.devtools.build.lib.vfs.Path; import com.google.devtools.build.lib.vfs.PathFragment; import com.google.devtools.build.lib.vfs.RootedPath; @@ -27,6 +30,7 @@ import com.google.devtools.build.skyframe.SkyKey; import com.google.devtools.build.skyframe.SkyValue; import java.io.IOException; +import java.util.List; /** * A SkyFunction to parse WORKSPACE files into a BuildFileAST. @@ -65,12 +69,39 @@ public class WorkspaceASTFunction implements SkyFunction { new IOException("Failed to parse WORKSPACE file"), Transience.PERSISTENT); } } - return new WorkspaceASTValue(ast); + return new WorkspaceASTValue(splitAST(ast)); } catch (IOException ex) { throw new WorkspaceASTFunctionException(ex, Transience.TRANSIENT); } } + /** + * Cut {@code ast} into a list of AST separated by load statements. We cut right before each load + * statement series. + */ + private static ImmutableList<BuildFileAST> splitAST(BuildFileAST ast) { + ImmutableList.Builder<BuildFileAST> asts = ImmutableList.builder(); + int prevIdx = 0; + boolean lastIsLoad = true; // don't cut if the first statement is a load. + List<Statement> statements = ast.getStatements(); + for (int idx = 0; idx < statements.size(); idx++) { + Statement st = statements.get(idx); + if (st instanceof LoadStatement) { + if (!lastIsLoad) { + asts.add(ast.subTree(prevIdx, idx)); + prevIdx = idx; + } + lastIsLoad = true; + } else { + lastIsLoad = false; + } + } + if (!statements.isEmpty()) { + asts.add(ast.subTree(prevIdx, statements.size())); + } + return asts.build(); + } + private static final class WorkspaceASTFunctionException extends SkyFunctionException { public WorkspaceASTFunctionException(Exception e, Transience transience) { super(e, transience); diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/WorkspaceASTValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/WorkspaceASTValue.java index 96f42dfa71..35479fca31 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/WorkspaceASTValue.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/WorkspaceASTValue.java @@ -14,25 +14,46 @@ package com.google.devtools.build.lib.skyframe; import com.google.common.base.Preconditions; +import com.google.common.collect.ImmutableList; import com.google.devtools.build.lib.syntax.BuildFileAST; import com.google.devtools.build.lib.vfs.RootedPath; import com.google.devtools.build.skyframe.SkyKey; import com.google.devtools.build.skyframe.SkyValue; +import java.util.List; + /** - * A SkyValue that stores the parsed WORKSPACE file as an AST. + * A SkyValue that stores the parsed WORKSPACE file as a list of AST. Each AST contains the part + * of the WORKSPACE file between the first load statement of a series of load statements and the + * last statement before the next load statement. As example, the comment indicate where the next + * file would be split: + * + * <p><code> + * # First AST + * load('//foo:bar.bzl', 'foobar') + * foo_bar = 1 + * + * # Second AST + * load('//foo:baz.bzl', 'foos') + * load('//bar:foo.bzl', 'bars') + * foos() + * bars() + * + * # Third AST + * load('//:bleh.bzl', 'bleh') + * </code> */ public class WorkspaceASTValue implements SkyValue { - private final BuildFileAST ast; + private final ImmutableList<BuildFileAST> asts; - public WorkspaceASTValue(BuildFileAST ast) { - Preconditions.checkNotNull(ast); - this.ast = ast; + public WorkspaceASTValue(List<BuildFileAST> asts) { + Preconditions.checkNotNull(asts); + this.asts = ImmutableList.copyOf(asts); } - public BuildFileAST getAST() { - return ast; + public ImmutableList<BuildFileAST> getASTs() { + return asts; } public static SkyKey key(RootedPath path) { diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/WorkspaceFileFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/WorkspaceFileFunction.java index fd948ee6f6..305d2e89fc 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/WorkspaceFileFunction.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/WorkspaceFileFunction.java @@ -54,9 +54,10 @@ public class WorkspaceFileFunction implements SkyFunction { public SkyValue compute(SkyKey skyKey, Environment env) throws WorkspaceFileFunctionException, InterruptedException { - RootedPath workspaceRoot = ((WorkspaceFileKey) skyKey.argument()).getPath(); + WorkspaceFileKey key = (WorkspaceFileKey) skyKey.argument(); + RootedPath workspaceRoot = key.getPath(); WorkspaceASTValue workspaceASTValue = - (WorkspaceASTValue) env.getValue(new SkyKey(SkyFunctions.WORKSPACE_AST, workspaceRoot)); + (WorkspaceASTValue) env.getValue(WorkspaceASTValue.key(workspaceRoot)); if (workspaceASTValue == null) { return null; } @@ -75,14 +76,15 @@ public class WorkspaceFileFunction implements SkyFunction { directories.getEmbeddedBinariesRoot(), directories.getWorkspace()); try { - BuildFileAST ast = workspaceASTValue.getAST(); - PackageFunction.SkylarkImportResult importResult = - PackageFunction.fetchImportsFromBuildFile( - repoWorkspace, Label.EXTERNAL_PACKAGE_IDENTIFIER, ast, env, null); - if (importResult != null) { - parser.execute(ast, importResult.importMap); - } else { - return null; + for (BuildFileAST ast : workspaceASTValue.getASTs()) { + PackageFunction.SkylarkImportResult importResult = + PackageFunction.fetchImportsFromBuildFile( + repoWorkspace, Label.EXTERNAL_PACKAGE_IDENTIFIER, ast, env, null); + if (importResult != null) { + parser.execute(ast, importResult.importMap); + } else { + return null; + } } } catch (PackageFunctionException e) { throw new WorkspaceFileFunctionException(e, Transience.PERSISTENT); |