aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/skyframe
diff options
context:
space:
mode:
authorGravatar tomlu <tomlu@google.com>2018-08-02 11:49:08 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-08-02 11:50:28 -0700
commit04e9281ad2353ffa75f05c3e67c55d6fa2130a1c (patch)
treea0d1a11b9e3b5cdfb776029fa9795cdb0f22c643 /src/main/java/com/google/devtools/build/lib/skyframe
parentd1a203bbdd2033ec8049b39242189e1cc76a9e8e (diff)
Thread a path resolver through target/aspect complete event.
At the moment, an identity path resolver is passed. This will later be replaced by a contextual path resolver. RELNOTES: None PiperOrigin-RevId: 207138772
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe')
-rw-r--r--src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java13
1 files changed, 9 insertions, 4 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java
index 0f07d7ee79..5d1fa1c7a9 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java
@@ -15,6 +15,7 @@ package com.google.devtools.build.lib.skyframe;
import com.google.devtools.build.lib.actions.ActionExecutionException;
import com.google.devtools.build.lib.actions.Artifact;
+import com.google.devtools.build.lib.actions.ArtifactPathResolver;
import com.google.devtools.build.lib.actions.ArtifactSkyKey;
import com.google.devtools.build.lib.actions.MissingInputFileException;
import com.google.devtools.build.lib.analysis.AspectCompleteEvent;
@@ -91,6 +92,7 @@ public final class CompletionFunction<TValue extends SkyValue, TResult extends S
ExtendedEventHandler.Postable createSucceeded(
SkyKey skyKey,
TValue value,
+ ArtifactPathResolver pathResolver,
TopLevelArtifactContext topLevelArtifactContext,
Environment env)
throws InterruptedException;
@@ -184,6 +186,7 @@ public final class CompletionFunction<TValue extends SkyValue, TResult extends S
public ExtendedEventHandler.Postable createSucceeded(
SkyKey skyKey,
ConfiguredTargetValue value,
+ ArtifactPathResolver pathResolver,
TopLevelArtifactContext topLevelArtifactContext,
Environment env)
throws InterruptedException {
@@ -197,10 +200,10 @@ public final class CompletionFunction<TValue extends SkyValue, TResult extends S
TopLevelArtifactHelper.getAllArtifactsToBuild(target, topLevelArtifactContext);
if (((TargetCompletionKey) skyKey.argument()).willTest()) {
return TargetCompleteEvent.successfulBuildSchedulingTest(
- configuredTargetAndData, artifactsToBuild.getAllArtifactsByOutputGroup());
+ configuredTargetAndData, pathResolver, artifactsToBuild.getAllArtifactsByOutputGroup());
} else {
return TargetCompleteEvent.successfulBuild(
- configuredTargetAndData, artifactsToBuild.getAllArtifactsByOutputGroup());
+ configuredTargetAndData, pathResolver, artifactsToBuild.getAllArtifactsByOutputGroup());
}
}
}
@@ -269,11 +272,12 @@ public final class CompletionFunction<TValue extends SkyValue, TResult extends S
public ExtendedEventHandler.Postable createSucceeded(
SkyKey skyKey,
AspectValue value,
+ ArtifactPathResolver pathResolver,
TopLevelArtifactContext topLevelArtifactContext,
Environment env) {
ArtifactsToBuild artifacts =
TopLevelArtifactHelper.getAllArtifactsToBuild(value, topLevelArtifactContext);
- return AspectCompleteEvent.createSuccessful(value, artifacts);
+ return AspectCompleteEvent.createSuccessful(value, pathResolver, artifacts);
}
}
@@ -362,7 +366,8 @@ public final class CompletionFunction<TValue extends SkyValue, TResult extends S
return null;
}
ExtendedEventHandler.Postable postable =
- completor.createSucceeded(skyKey, value, topLevelContext, env);
+ completor.createSucceeded(
+ skyKey, value, ArtifactPathResolver.IDENTITY, topLevelContext, env);
if (postable == null) {
return null;
}