aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/skyframe/packages
diff options
context:
space:
mode:
authorGravatar janakr <janakr@google.com>2017-09-22 14:47:55 -0400
committerGravatar John Cater <jcater@google.com>2017-09-25 09:38:26 -0400
commit6acf6f00ab1b4dd8805b962f20f2897fc431e878 (patch)
tree877b8201b007eede845ea580c1e7c5c6fda5b47a /src/main/java/com/google/devtools/build/lib/skyframe/packages
parent3c6c45fe9653b53288f99c68fc6b9d28da5a48ba (diff)
Remove PrecomputedValue for BlazeDirectories. All consumers have the value injected directly, which makes sense, because it's immutable over the lifetime of the server.
Step 3. PiperOrigin-RevId: 169717587
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/packages')
-rw-r--r--src/main/java/com/google/devtools/build/lib/skyframe/packages/AbstractPackageLoader.java7
1 files changed, 2 insertions, 5 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/packages/AbstractPackageLoader.java b/src/main/java/com/google/devtools/build/lib/skyframe/packages/AbstractPackageLoader.java
index fa12d24362..f5b0690752 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/packages/AbstractPackageLoader.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/packages/AbstractPackageLoader.java
@@ -213,15 +213,13 @@ public abstract class AbstractPackageLoader implements PackageLoader {
makePreinjectedDiff(
pkgLocator,
builder.defaultsPackageContents,
- ImmutableList.copyOf(builder.extraPrecomputedValues),
- directories);
+ ImmutableList.copyOf(builder.extraPrecomputedValues));
}
private static ImmutableDiff makePreinjectedDiff(
PathPackageLocator pkgLocator,
String defaultsPackageContents,
- ImmutableList<PrecomputedValue.Injected> extraPrecomputedValues,
- BlazeDirectories directories) {
+ ImmutableList<PrecomputedValue.Injected> extraPrecomputedValues) {
final Map<SkyKey, SkyValue> valuesToInject = new HashMap<>();
Injectable injectable =
new Injectable() {
@@ -245,7 +243,6 @@ public abstract class AbstractPackageLoader implements PackageLoader {
Options.getDefaults(SkylarkSemanticsOptions.class));
PrecomputedValue.DEFAULTS_PACKAGE_CONTENTS.set(injectable, defaultsPackageContents);
PrecomputedValue.BLACKLISTED_PACKAGE_PREFIXES_FILE.set(injectable, PathFragment.EMPTY_FRAGMENT);
- PrecomputedValue.BLAZE_DIRECTORIES.set(injectable, directories);
return new ImmutableDiff(ImmutableList.<SkyKey>of(), valuesToInject);
}