diff options
| author |  nharmata <nharmata@google.com> | 2018-02-23 11:37:51 -0800 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-02-23 11:39:16 -0800 |
| commit | 3fb7d34ed00fa88f2d9d5a2aa530e3a4cf70c1d9 (patch) | |
| tree | ad788977eb72a3d3fc1f208f323de99dbf362306 /src/main/java/com/google/devtools/build/lib/skyframe/packages | |
| parent | d829236e9feee234fde3a4aed36e1349b7e9ee16 (diff) | |
A couple quality-of-life improvements for Bazel devs, in response to an email from philwo@.
(i) Only have TimestampGranularityMonitor log the first file of relevance. This reduces log spam, especially in tests, while still maintaining useful information in the logs.
(ii) Don't have ExternalFilesHelper log the fact that it encountered an external file when we're in a unit test or an integration test. Tests, especially bazel tests that use external repositories, tend to involve lots of "external" files.
RELNOTES: None
PiperOrigin-RevId: 186799176
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/packages')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/packages/AbstractPackageLoader.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/packages/AbstractPackageLoader.java b/src/main/java/com/google/devtools/build/lib/skyframe/packages/AbstractPackageLoader.java index a079b3fca4..850687dcc1 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/packages/AbstractPackageLoader.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/packages/AbstractPackageLoader.java @@ -228,7 +228,7 @@ public abstract class AbstractPackageLoader implements PackageLoader { this.skyframeThreads = builder.skyframeThreads; this.directories = builder.directories; - this.externalFilesHelper = new ExternalFilesHelper( + this.externalFilesHelper = ExternalFilesHelper.create( pkgLocatorRef, ExternalFileAction.DEPEND_ON_EXTERNAL_PKG_FOR_EXTERNAL_REPO_PATHS, directories); |