PackageLoader.loadPackages() tolerates duplicates in the list of packages to load.

RELNOTES: None
PiperOrigin-RevId: 171298089

1 files changed, 3 insertions, 4 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/packages/AbstractPackageLoader.java b/src/main/java/com/google/devtools/build/lib/skyframe/packages/AbstractPackageLoader.java
index e8a6086fef..9ea8e98492 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/packages/AbstractPackageLoader.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/packages/AbstractPackageLoader.java
@@ -252,11 +252,10 @@ public abstract class AbstractPackageLoader implements PackageLoader {
   @Override
   public ImmutableMap<PackageIdentifier, PackageLoader.PackageOrException> loadPackages(
       Iterable<? extends PackageIdentifier> pkgIds) throws InterruptedException {
-    ImmutableList.Builder<SkyKey> keysBuilder = ImmutableList.builder();
-    for (PackageIdentifier pkgId : pkgIds) {
-      keysBuilder.add(PackageValue.key(pkgId));
+    ArrayList<SkyKey> keys = new ArrayList<>();
+    for (PackageIdentifier pkgId : ImmutableSet.copyOf(pkgIds)) {
+      keys.add(PackageValue.key(pkgId));
     }
-    ImmutableList<SkyKey> keys = keysBuilder.build();
 
     EvaluationResult<PackageValue> evalResult =
         makeFreshDriver().evaluate(keys, /*keepGoing=*/ true, skyframeThreads, reporter);