diff options
| author |  twerth <twerth@google.com> | 2018-03-07 02:46:37 -0800 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-03-07 02:47:50 -0800 |
| commit | e5626a53e108fe9de2af84fb2cf0c38eb72cdc4f (patch) | |
| tree | 4172ed792208bc96eb4e75be282dcfd656d5a022 /src/main/java/com/google/devtools/build/lib/skyframe/actiongraph/KnownConfigurations.java | |
| parent | 54027090564fee03bc7f710dfe37e61218fef519 (diff) | |
Don't use computeIfAbsent in action graph dumping.
computeIfAbsent may throw (on best effort basis) a
ConcurrentModificationException if you change the underlying Map in the
computeIfAbsent call, for example when you call computeIfAbsent recursively in
the mappingFunction.
NestedSets are an inherent recursive structure, so we need to call
computeIfAbsent recursively in the action graph dump.
Since computeIfAbsent doesn't throw the exception all the time, it's hard to
come up with a reliable test case.
RELNOTES: None
PiperOrigin-RevId: 188151283
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/actiongraph/KnownConfigurations.java')
0 files changed, 0 insertions, 0 deletions