Clean up an unnecessary field in NoSuchTargetException.

--
MOS_MIGRATED_REVID=90081310

1 files changed, 5 insertions, 3 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/TransitiveTargetFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/TransitiveTargetFunction.java
index 8e818f3df1..8f1838a22d 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/TransitiveTargetFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/TransitiveTargetFunction.java
@@ -79,15 +79,17 @@ public class TransitiveTargetFunction implements SkyFunction {
       if (target == null) {
         throw new TransitiveTargetFunctionException(e);
       }
+
+      // So we now have a Target here, but the only way for that to happen is if the package loaded
+      // at least partially, but had an error.
       successfulTransitiveLoading = false;
       transitiveRootCauses.add(label);
       errorLoadingTarget = e;
-      packageLoadedSuccessfully = e.getPackageLoadedSuccessfully();
+      packageLoadedSuccessfully = false;
     } catch (NoSuchPackageException e) {
       throw new TransitiveTargetFunctionException(e);
     } catch (NoSuchThingException e) {
-      throw new IllegalStateException(e
-          + " not NoSuchTargetException or NoSuchPackageException");
+      throw new IllegalStateException(e + " not NoSuchTargetException or NoSuchPackageException");
     }
 
     NestedSetBuilder<PackageIdentifier> transitiveSuccessfulPkgs = NestedSetBuilder.stableOrder();