aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/skyframe/ToolchainResolutionValue.java
diff options
context:
space:
mode:
authorGravatar janakr <janakr@google.com>2018-02-14 14:08:45 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2018-02-14 14:10:01 -0800
commit40d0077016dee31865af5246cbd6b2953d6386b3 (patch)
treebc61c4057476ecfa5b25b6f37d2aa88bca05b7dd /src/main/java/com/google/devtools/build/lib/skyframe/ToolchainResolutionValue.java
parentae52720bd38f1e1a29dc6d6910e6a0da95eb9236 (diff)
Start slimming down ToolchainResolutionKey: get rid of BuildConfiguration. The real blocker is PlatformInfo, which is coming.
PiperOrigin-RevId: 185742130
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/ToolchainResolutionValue.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/skyframe/ToolchainResolutionValue.java13
1 files changed, 6 insertions, 7 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/ToolchainResolutionValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/ToolchainResolutionValue.java
index 1f39059adf..f71c3bdf07 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/ToolchainResolutionValue.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/ToolchainResolutionValue.java
@@ -17,7 +17,6 @@ package com.google.devtools.build.lib.skyframe;
import com.google.auto.value.AutoValue;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
-import com.google.devtools.build.lib.analysis.config.BuildConfiguration;
import com.google.devtools.build.lib.analysis.platform.PlatformInfo;
import com.google.devtools.build.lib.cmdline.Label;
import com.google.devtools.build.skyframe.SkyFunctionName;
@@ -36,12 +35,12 @@ public abstract class ToolchainResolutionValue implements SkyValue {
// A key representing the input data.
public static SkyKey key(
- BuildConfiguration configuration,
+ BuildConfigurationValue.Key configurationKey,
Label toolchainType,
PlatformInfo targetPlatform,
List<PlatformInfo> availableExecutionPlatforms) {
return ToolchainResolutionKey.create(
- configuration, toolchainType, targetPlatform, availableExecutionPlatforms);
+ configurationKey, toolchainType, targetPlatform, availableExecutionPlatforms);
}
/** {@link SkyKey} implementation used for {@link ToolchainResolutionFunction}. */
@@ -52,16 +51,16 @@ public abstract class ToolchainResolutionValue implements SkyValue {
return SkyFunctions.TOOLCHAIN_RESOLUTION;
}
- public abstract BuildConfiguration configuration();
+ abstract BuildConfigurationValue.Key configurationKey();
public abstract Label toolchainType();
public abstract PlatformInfo targetPlatform();
- public abstract ImmutableList<PlatformInfo> availableExecutionPlatforms();
+ abstract ImmutableList<PlatformInfo> availableExecutionPlatforms();
- public static ToolchainResolutionKey create(
- BuildConfiguration configuration,
+ static ToolchainResolutionKey create(
+ BuildConfigurationValue.Key configuration,
Label toolchainType,
PlatformInfo targetPlatform,
List<PlatformInfo> availableExecutionPlatforms) {