aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/skyframe/ToolchainResolutionFunction.java
diff options
context:
space:
mode:
authorGravatar John Cater <jcater@google.com>2018-07-17 12:22:24 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-07-17 12:24:16 -0700
commitddebc72255212c808db21d146078b3b3f5897038 (patch)
treefb0f6c806419c0c25a2564b9d88dcc39ea98c768 /src/main/java/com/google/devtools/build/lib/skyframe/ToolchainResolutionFunction.java
parent474b896bfdb8c54640aa3f96bd3c84407b6349d4 (diff)
Move platform lookup to new dedicated helper class.
Change-Id: I2195a3f7d60e9835bc00d6f151ea91271fdccf6f PiperOrigin-RevId: 204954233
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/ToolchainResolutionFunction.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/skyframe/ToolchainResolutionFunction.java7
1 files changed, 4 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/ToolchainResolutionFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/ToolchainResolutionFunction.java
index 737bbd8982..0667d196b3 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/ToolchainResolutionFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/ToolchainResolutionFunction.java
@@ -27,8 +27,8 @@ import com.google.devtools.build.lib.cmdline.Label;
import com.google.devtools.build.lib.events.Event;
import com.google.devtools.build.lib.events.EventHandler;
import com.google.devtools.build.lib.packages.NoSuchThingException;
+import com.google.devtools.build.lib.skyframe.PlatformLookupUtil.InvalidPlatformException;
import com.google.devtools.build.lib.skyframe.RegisteredToolchainsFunction.InvalidToolchainLabelException;
-import com.google.devtools.build.lib.skyframe.ToolchainUtil.InvalidPlatformException;
import com.google.devtools.build.skyframe.SkyFunction;
import com.google.devtools.build.skyframe.SkyFunctionException;
import com.google.devtools.build.skyframe.SkyKey;
@@ -111,14 +111,15 @@ public class ToolchainResolutionFunction implements SkyFunction {
// Load the PlatformInfo needed to check constraints.
Map<ConfiguredTargetKey, PlatformInfo> platforms;
try {
+
platforms =
- ToolchainUtil.getPlatformInfo(
+ PlatformLookupUtil.getPlatformInfo(
new ImmutableList.Builder<ConfiguredTargetKey>()
.add(targetPlatformKey)
.addAll(availableExecutionPlatformKeys)
.build(),
env);
- if (platforms == null) {
+ if (env.valuesMissing()) {
return null;
}
} catch (InvalidPlatformException e) {