Use static creation method for SkyKey. This allows interning SkyKeys as they are created, as opposed to when they are requested from the ParallelEvaluator. That delay can lead to large memory spikes and churn.

--
MOS_MIGRATED_REVID=116224565

1 files changed, 11 insertions, 8 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/TestCompletionValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/TestCompletionValue.java
index eb2cfd4976..4cb899826a 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/TestCompletionValue.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/TestCompletionValue.java
@@ -32,18 +32,21 @@ public class TestCompletionValue implements SkyValue {
   private TestCompletionValue() { }
 
   public static SkyKey key(LabelAndConfiguration lac, boolean exclusive) {
-    return new SkyKey(SkyFunctions.TEST_COMPLETION, new TestCompletionKey(lac, exclusive));
+    return SkyKey.create(SkyFunctions.TEST_COMPLETION, new TestCompletionKey(lac, exclusive));
   }
 
   public static Iterable<SkyKey> keys(Collection<ConfiguredTarget> targets,
                                       final boolean exclusive) {
-    return Iterables.transform(targets, new Function<ConfiguredTarget, SkyKey>() {
-      @Override
-      public SkyKey apply(ConfiguredTarget ct) {
-        return new SkyKey(SkyFunctions.TEST_COMPLETION, 
-            new TestCompletionKey(new LabelAndConfiguration(ct), exclusive));
-      }
-    });
+    return Iterables.transform(
+        targets,
+        new Function<ConfiguredTarget, SkyKey>() {
+          @Override
+          public SkyKey apply(ConfiguredTarget ct) {
+            return SkyKey.create(
+                SkyFunctions.TEST_COMPLETION,
+                new TestCompletionKey(new LabelAndConfiguration(ct), exclusive));
+          }
+        });
   }
   
   static class TestCompletionKey {