aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/skyframe/SkylarkModuleCycleReporter.java
diff options
context:
space:
mode:
authorGravatar Ulf Adams <ulfjack@google.com>2015-03-05 14:47:37 +0000
committerGravatar Han-Wen Nienhuys <hanwen@google.com>2015-03-05 18:31:47 +0000
commit07dba941e21619830adcbcae10c5942cf3343f26 (patch)
treec0e7b1250bf547b20398a0c3a437864b7b915383 /src/main/java/com/google/devtools/build/lib/skyframe/SkylarkModuleCycleReporter.java
parenta34d5071784ff51f68714b61f4100c35f1e4db3a (diff)
Some cleanup changes.
-- MOS_MIGRATED_REVID=87821306
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/SkylarkModuleCycleReporter.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/skyframe/SkylarkModuleCycleReporter.java9
1 files changed, 5 insertions, 4 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkylarkModuleCycleReporter.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkylarkModuleCycleReporter.java
index a0f37a9d4a..7fd1b60fb9 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/SkylarkModuleCycleReporter.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkylarkModuleCycleReporter.java
@@ -40,7 +40,7 @@ public class SkylarkModuleCycleReporter implements CyclesReporter.SingleCycleRep
public boolean maybeReportCycle(SkyKey topLevelKey, CycleInfo cycleInfo, boolean alreadyReported,
EventHandler eventHandler) {
ImmutableList<SkyKey> pathToCycle = cycleInfo.getPathToCycle();
- if (pathToCycle.size() == 0) {
+ if (pathToCycle.isEmpty()) {
return false;
}
SkyKey lastPathElement = cycleInfo.getPathToCycle().get(pathToCycle.size() - 1);
@@ -49,9 +49,10 @@ public class SkylarkModuleCycleReporter implements CyclesReporter.SingleCycleRep
} else if (Iterables.all(cycleInfo.getCycle(), IS_SKYLARK_MODULE_SKY_KEY)
// The last element of the path to the cycle has to be a PackageFunction.
&& IS_PACKAGE_SKY_KEY.apply(lastPathElement)) {
- StringBuilder cycleMessage = new StringBuilder()
- .append(((PackageIdentifier) lastPathElement.argument()).toString() + "/BUILD: ")
- .append("cycle in referenced extension files: ");
+ StringBuilder cycleMessage =
+ new StringBuilder()
+ .append(((PackageIdentifier) lastPathElement.argument()) + "/BUILD: ")
+ .append("cycle in referenced extension files: ");
AbstractLabelCycleReporter.printCycle(cycleInfo.getCycle(), cycleMessage,
new Function<SkyKey, String>() {