Allow Skylark import lookup values to be computed inline in order to avoid reifying them in the Skyframe graph.

--
MOS_MIGRATED_REVID=103758591

1 files changed, 6 insertions, 0 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkylarkImportLookupValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkylarkImportLookupValue.java
index 0ac9fd4402..390f958658 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/SkylarkImportLookupValue.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkylarkImportLookupValue.java
@@ -71,6 +71,12 @@ public class SkylarkImportLookupValue implements SkyValue {
     return key(pkgIdentifier.getRepository(), pkgIdentifier.getPackageFragment());
   }
 
+  /**
+   * Returns a SkyKey to get a SkylarkImportLookupValue. Note that SkylarkImportLookupValue
+   * computations may be inlined to avoid having them in the graph. Callers should confirm whether
+   * inlining is desired and either do the computation directly themselves (if inlined) or request
+   * this key's value from the environment (if not).
+   */
   static SkyKey key(RepositoryName repo, PathFragment fromFile, PathFragment fileToImport)
       throws ASTLookupInputException {
     PathFragment computedPath;