Fix bug in skyframe-based test-suite expansion

It was tracking filtered tests and then applying the filter at the next higher
level.

I also added a bunch of comments - we actually have four implementations of
test suite expansion, and they are not consistent. Sorry about that.

PiperOrigin-RevId: 199629485

1 files changed, 2 insertions, 2 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeTargetPatternEvaluator.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeTargetPatternEvaluator.java
index 42265a46f1..4c8cf80a27 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeTargetPatternEvaluator.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeTargetPatternEvaluator.java
@@ -163,8 +163,8 @@ final class SkyframeTargetPatternEvaluator implements TargetPatternEvaluator {
   private TargetPatternsResultBuilder createTargetPatternEvaluatorUtil(
       FilteringPolicy policy, ExtendedEventHandler eventHandler, boolean keepGoing) {
     return policy == FilteringPolicies.FILTER_TESTS
-        ? new TestTargetPatternsResultBuilder(skyframeExecutor.getPackageManager(), eventHandler,
-          keepGoing)
+        ? new TestTargetPatternsResultBuilder(
+            skyframeExecutor.getPackageManager(), eventHandler, keepGoing)
         : new BuildTargetPatternsResultBuilder();
   }