aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageManager.java
diff options
context:
space:
mode:
authorGravatar Lukacs Berki <lberki@google.com>2015-07-07 07:58:15 +0000
committerGravatar Lukacs Berki <lberki@google.com>2015-07-07 08:42:21 +0000
commitb21df3d2a022a24f66c88671ab7694c9b0d9735c (patch)
tree015c696c5d45076255570e0d05ef6fabafdeac9f /src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageManager.java
parent7d02845041bbd0342f9e6dca69627bff5864aa71 (diff)
Rollback of accidentally submitted change.
-- MOS_MIGRATED_REVID=97648982
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageManager.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageManager.java8
1 files changed, 5 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageManager.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageManager.java
index 7ffb79ce89..3e9b6cad1f 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageManager.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageManager.java
@@ -13,6 +13,7 @@
// limitations under the License.
package com.google.devtools.build.lib.skyframe;
+import com.google.devtools.build.lib.cmdline.LabelValidator;
import com.google.devtools.build.lib.concurrent.ThreadSafety.ThreadSafe;
import com.google.devtools.build.lib.events.EventHandler;
import com.google.devtools.build.lib.packages.NoSuchPackageException;
@@ -135,7 +136,7 @@ class SkyframePackageManager implements PackageManager {
}
@Override
- public boolean isPackage(EventHandler eventHandler, PackageIdentifier packageName) {
+ public boolean isPackage(EventHandler eventHandler, String packageName) {
return getBuildFileForPackage(packageName) != null;
}
@@ -146,10 +147,11 @@ class SkyframePackageManager implements PackageManager {
@ThreadSafe
@Override
- public Path getBuildFileForPackage(PackageIdentifier packageName) {
+ public Path getBuildFileForPackage(String packageName) {
// Note that this method needs to be thread-safe, as it is currently used concurrently by
// legacy blaze code.
- if (packageLoader.isPackageDeleted(packageName)) {
+ if (packageLoader.isPackageDeleted(packageName)
+ || LabelValidator.validatePackageName(packageName) != null) {
return null;
}
// TODO(bazel-team): Use a PackageLookupValue here [skyframe-loading]