diff options
author | Ulf Adams <ulfjack@google.com> | 2015-12-11 11:17:49 +0000 |
---|---|---|
committer | David Chen <dzc@google.com> | 2015-12-11 17:08:37 +0000 |
commit | 6089e5be0d8f84ea3c96b5f46bf2387491fe7178 (patch) | |
tree | a9353f0e6e040aecb33d37cf9d8f1d47128d4eb5 /src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageLoaderWithValueEnvironment.java | |
parent | cb8f278f42f3c8c7c69314c8cf68175718298216 (diff) |
Clean up the configuration-related code paths a bit.
- If we have a class object available, we can use .cast(Object)
- Only store the required options objects in CppConfigurationParameters
rather than keeping the entire BuildOptions
--
MOS_MIGRATED_REVID=109981236
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageLoaderWithValueEnvironment.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageLoaderWithValueEnvironment.java | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageLoaderWithValueEnvironment.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageLoaderWithValueEnvironment.java index 95ff677240..95bd400795 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageLoaderWithValueEnvironment.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframePackageLoaderWithValueEnvironment.java @@ -72,7 +72,6 @@ class SkyframePackageLoaderWithValueEnvironment implements PackageProviderForCon } } - @SuppressWarnings("unchecked") @Override public <T extends Fragment> T getFragment(BuildOptions buildOptions, Class<T> fragmentType) throws InvalidConfigurationException { @@ -82,7 +81,7 @@ class SkyframePackageLoaderWithValueEnvironment implements PackageProviderForCon if (fragmentNode == null) { return null; } - return (T) fragmentNode.getFragment(); + return fragmentType.cast(fragmentNode.getFragment()); } @Override |