diff options
author | 2015-09-25 15:14:27 +0000 | |
---|---|---|
committer | 2015-09-28 11:38:53 +0000 | |
commit | dc7af5392e60b6b98ebaea7ead11d47218a8df03 (patch) | |
tree | 9ede118e9c37880d647a64d4107480d2f1d92c6e /src/main/java/com/google/devtools/build/lib/skyframe/SkyframeLabelVisitor.java | |
parent | fb39c4efa8e9b7da0329a384ba7d05969c890c20 (diff) |
Split the PackageManager type hierarchy; no longer inherit LoadedPackageProv.
This limits the exposure of LoadedPackageProvider, such that there will be
no regressions in the use of getLoadedTarget. Unfortunately, fully removing
LoadedPackageProvider is more work than I'm willing to take on right now, and
this is the cleanest intermediate solution I could come up with.
This unblocks my other work (removing SkyframeExecutor.errorEventHandler).
Someone else will have to shave this yak.
--
MOS_MIGRATED_REVID=103943375
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/SkyframeLabelVisitor.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/SkyframeLabelVisitor.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeLabelVisitor.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeLabelVisitor.java index 321c6f043b..f325dc3ba3 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeLabelVisitor.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeLabelVisitor.java @@ -71,8 +71,8 @@ final class SkyframeLabelVisitor implements TransitivePackageLoader { throws InterruptedException { rootCauses.clear(); lastBuildKeepGoing = false; - EvaluationResult<TransitiveTargetValue> result = - transitivePackageLoader.loadTransitiveTargets(targetsToVisit, labelsToVisit, keepGoing); + EvaluationResult<TransitiveTargetValue> result = transitivePackageLoader.loadTransitiveTargets( + eventHandler, targetsToVisit, labelsToVisit, keepGoing); updateVisitedValues(result.values()); lastBuildKeepGoing = keepGoing; |