diff options
| author |  Janak Ramakrishnan <janakr@google.com> | 2016-04-18 16:34:28 +0000 |
|---|---|---|
| committer |  Damien Martin-Guillerez <dmarting@google.com> | 2016-04-19 09:42:12 +0000 |
| commit | 003893ba83393db94ba662f1400e4b83249c7680 (patch) | |
| tree | 34f0cc1e119d7874bbf17c4c1d32b2c48c0b297a /src/main/java/com/google/devtools/build/lib/skyframe/SkyframeLabelVisitor.java | |
| parent | 7c3c3f1d1e985f1d2b61466c57f1d89b1114b0a7 (diff) | |
Change misleading warning when an error is encountered while loading a target. We also no longer say that the target will not be built because it may well happen during a query, when no building is happening anyway.
--
MOS_MIGRATED_REVID=120130554
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/SkyframeLabelVisitor.java')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/SkyframeLabelVisitor.java | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeLabelVisitor.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeLabelVisitor.java index ec0defdf55..38c21117c1 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeLabelVisitor.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeLabelVisitor.java @@ -164,11 +164,7 @@ final class SkyframeLabelVisitor implements TransitivePackageLoader { } private static void warnAboutLoadingFailure(Label label, EventHandler eventHandler) { - eventHandler.handle(Event.warn( - // TODO(bazel-team): We use 'analyzing' here so that we print the same message as legacy - // Blaze. Once we get rid of legacy we should be able to change to 'loading' or - // similar. - "errors encountered while analyzing target '" + label + "': it will not be built")); + eventHandler.handle(Event.warn("errors encountered while loading target '" + label + "'")); } private static Set<Label> getRootCausesOfCycles(Label labelToLoad, Iterable<CycleInfo> cycles) { |