aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutorFactory.java
diff options
context:
space:
mode:
authorGravatar janakr <janakr@google.com>2017-09-22 16:55:31 -0400
committerGravatar John Cater <jcater@google.com>2017-09-25 09:38:48 -0400
commit92e402ba666f127204596c7c66c4b0022650e370 (patch)
tree4a4a3c4218a282ed86e6826d748ac22043cbf2d3 /src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutorFactory.java
parentc6ff86fa17b8372bad1311601ef3db96a74b968e (diff)
Remove unused "extraPrecomputedValues" from WorkspaceBuilder, and therefore remove all "precomputed values for analysis" from SkyframeExecutor. We use SkyframeExecutor#injectExtraPrecomputedValues these days.
This simplifies logic around when to inject precomputed values, and makes the graph more consistent. PiperOrigin-RevId: 169733304
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutorFactory.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutorFactory.java2
1 files changed, 0 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutorFactory.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutorFactory.java
index 225ffd3e7b..4ed5361730 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutorFactory.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutorFactory.java
@@ -43,7 +43,6 @@ public interface SkyframeExecutorFactory {
* @param diffAwarenessFactories
* @param allowedMissingInputs
* @param extraSkyFunctions
- * @param extraPrecomputedValues
* @param customDirtinessCheckers
* @return an instance of the SkyframeExecutor
* @throws AbruptExitException if the executor cannot be created
@@ -57,7 +56,6 @@ public interface SkyframeExecutorFactory {
Iterable<? extends DiffAwareness.Factory> diffAwarenessFactories,
Predicate<PathFragment> allowedMissingInputs,
ImmutableMap<SkyFunctionName, SkyFunction> extraSkyFunctions,
- ImmutableList<PrecomputedValue.Injected> extraPrecomputedValues,
Iterable<SkyValueDirtinessChecker> customDirtinessCheckers)
throws AbruptExitException;
}